21 Commits

Author SHA1 Message Date
Damiano Galassi
c5a4d181eb
MacGui: enable and fix more warnings. Review nullability annotations. 2019-08-12 10:19:00 +02:00
ritsuka
2837048a59 MacGui: add nullability annotations to the headers and use weak where is possible.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@7244 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-05-30 07:17:22 +00:00
ritsuka
48a9e54687 MacGui: convert the mac gui to Objective-C ARC.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6996 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-03-17 13:56:21 +00:00
ritsuka
677231f07d MacGui: Move the audio/subtitles selection logic out of the view controllers. Now it's possible to create a HBJob and apply a preset to without the UI classes help.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6741 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-01-13 08:08:04 +00:00
ritsuka
e5e00e722a MacGui: rename HBAudio class to HBAudioTrack.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6696 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-01-09 07:34:11 +00:00
ritsuka
77d37037be MacGui: clean up headers and imports.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6661 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-12-27 15:56:29 +00:00
ritsuka
7f6ec5084e MacGui: remove redundant "enabled" property in a few view controller. Cosmetics in HBController.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6660 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-12-27 12:29:00 +00:00
ritsuka
df8b2ff3e1 MacGui: change the queue to work with serialized HBJob objects, remove the NSDictionary job representation and the duplicate prepareJob method. Implement NSCopying protocol in HBJob.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6655 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-12-27 10:46:04 +00:00
ritsuka
01b16be689 MacGui: use HBJob when possible.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6633 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-12-21 06:34:10 +00:00
ritsuka
cdbf8a54bf MacGui: pass only the tracks array to the addTracksFromQueue: method, no need to pass the entire job dict.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6498 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-11-02 15:17:54 +00:00
ritsuka
a13b937ba0 MacGui: renamed HB*Settings classes to HB*Defaults. Added a “…” char to the “Configure Defaults” button.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6341 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-08-22 06:30:58 +00:00
ritsuka
6aee3b7518 MacGui: implemented the HBViewValidation protocol in each of the main window view controllers.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6285 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-08-10 16:05:07 +00:00
ritsuka
dd3518f0e6 MacGui: simplified the way the audio tracks are stored in the queue.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6267 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-08-04 16:46:17 +00:00
ritsuka
3fdfc2d020 MacGui: Adds a new sheet for audio defaults (presets), uses the same preset keys as the LinGui.
The built-in presets still use the languages from the Audio preferences.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6264 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-08-04 07:12:12 +00:00
ritsuka
31283b4427 MacGUI: Refactored the controller code for the video/audio/subtitles/chapters view:
Added a xib file and a NSViewController subclass for each tab of the main HandBrake window.
Each view controller now to responds to the HBContainerChangedNotification and HBTitleChangedNotification notifications instead of using a custom way to notify changes.
Converted the modified .xibs to the Xcode 5.1 format.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6231 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-07-15 18:30:51 +00:00
Rodeo
d7ad9c9682 decavcodec: DRC support.
Adds DRC support for E-AC-3 audio (as well as any future libavcodec decoders with DRC support).


git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@5995 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-01-25 23:24:48 +00:00
ritsuka
edc929027e MacGUI: fixed a number of leaks/null-deferences/dead-code found by clang static analyzer.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@5838 b64f7644-9d1e-0410-96f1-a4d463321fa5
2013-10-15 11:36:51 +00:00
dynaflash
b3b9ef3add MacGui: HBAudio Indentation Cleanup
- Patch by Rodeo ... Thanks!
- Change hard tabs to 4 spaces
- Place the opening bracket of if, else if, else, while and for statements on another line, not the same line as the condition.
- Xcode's Edit > Format > Re-Indent on all files.
- This patch is purely about cosmetics and indentation. There shouldn't be any change in behavior.
- As per https://reviews.handbrake.fr/r/101/


git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4054 b64f7644-9d1e-0410-96f1-a4d463321fa5
2011-06-13 20:27:46 +00:00
dynaflash
e4683402a0 MacGui: Clean up internal architecture of HB Audio and HBAudioController
- patch by blindjimmy ... as always .... thank you!
- as per https://reviews.handbrake.fr/r/81/

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@4002 b64f7644-9d1e-0410-96f1-a4d463321fa5
2011-05-26 15:48:37 +00:00
dynaflash
e89cc6b139 MacGui: Audio ... Add an "Add All Tracks" button to the audio tab.
- Patch by circleone... Thanks again!
- Adds all available source tracks at the default mixdown etc. to the macgui in one click.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@3536 b64f7644-9d1e-0410-96f1-a4d463321fa5
2010-09-16 17:35:39 +00:00
dynaflash
b8353118c5 MacGui: Audio ... Allow more than 4 audio tracks.
- Patch courtesy of circleone ...  Thanks!
- Use a NSTableView to dynamically add/delete audio tracks ala the Subtitle tab.
- Sets a 24 track limit until someone tests more than 24 tracks (the libhb 8 track limit was removed as per http://trac.handbrake.fr/changeset/3531).
- Replaces the old static 4 tracks to a dynamic array.
- Moves macgui audio handling to a separate class.
Known caveats: 
- Borks queue editing which needs a revamp anyway.
- Queue window display needs to be adjusted to show more than 4 tracks appropriately. Again, its cosmetic and is not a show stopper.
- There may be other possible unknown side effects even though tested on all presets. That said, I feel it needs to get in so that we can get feedback from nightlies.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@3532 b64f7644-9d1e-0410-96f1-a4d463321fa5
2010-09-15 17:49:16 +00:00