46 Commits

Author SHA1 Message Date
Damiano Galassi
288b2efbab
MacGui: avoid NSURL to path conversions and path based methods 2024-07-31 18:25:37 +02:00
Damiano Galassi
32b43f8605
MacGui: limit the activity log refresh rate to 10 Hz to avoid overloading the main thread and making the UI unresponsive when too many messages are written to the log in a short time. 2024-04-15 21:31:47 +02:00
Damiano Galassi
b4e2125312
MacGui: store the activity log is a separate buffer when the activity window is closed. The activity window is lazy loaded, but once loaded the lines were added to the NSTextView even when the window was closed, causing UI slowdowns when many messages were written to the log, like in a recursive scan. 2024-04-10 08:25:57 +02:00
Damiano Galassi
5c8ab00aa7
MacGui: disable tabbing mode in the activity log window. 2024-02-27 19:34:31 +01:00
Damiano Galassi
8465fc2fd9
MacGui: enable CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER warning and fix the related warnings. Improved toolbars and alerts when compiling with the macOS 11 sdk. 2020-06-27 14:13:12 +02:00
Nomis101
20fe4b6ebd Gardening: Clean up trailing whitespace
Remove trailing whitespace in "*.c",  "*.m",  "*.h" and "*.cpp" files.
2019-11-04 22:41:20 +00:00
Damiano Galassi
79740fb9ba
MacGui: fix a few warnings when building in Xcode 11. 2019-09-13 12:52:20 +02:00
Damiano Galassi
bed55e0588
MacGui: move the queue libhb instance to an xpc service. 2019-08-11 09:07:20 +02:00
Nomis101
38c3ba1835 Fix some typos (#2202)
Fix some typos
2019-07-31 07:27:27 +02:00
Nomis101
5351c1f619
build: Add --enable-hardening flag to enable stack protection and enhanced buffer overflow protection.
Prints the hardening status on global init to the log. Closes #2027. Was #2040.
2019-06-19 14:10:45 -04:00
Damiano Galassi
0e8eb04fd7
MacGui: fix another round of deprecation warnings. Remove drawer code. 2018-06-10 09:12:18 +02:00
Damiano Galassi
86997ab85d
MaGui: fix activity text color in dark mode. 2018-06-07 14:28:07 +02:00
Damiano Galassi
ed8c11eed0 MacGui: check if the activity log is not nil before adding it to HBOutputRedirect. 2016-01-16 15:06:39 +01:00
Damiano Galassi
93a0685f2c MacGui: enable core animation in the activity window so the bottom corners of the window will be rounded like they should, and move the search bar setting directly in the xib because we no longer need to support 10.6 2015-09-04 09:06:42 +02:00
ritsuka
f360714523 MacGui: run the Xcode "convert to modern objective-c" on the entire project.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@7075 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-04-09 19:43:33 +00:00
ritsuka
13d0d1d579 MacGui: changed the Preview Window and Picture Panel behaviour to avoid the hide and show thing when loading a new title, now they can always be opened even if no title is loaded.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@7065 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-04-07 16:14:30 +00:00
ritsuka
48a9e54687 MacGui: convert the mac gui to Objective-C ARC.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6996 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-03-17 13:56:21 +00:00
ritsuka
53508d57a4 MacGui: add a preference to toggle the log cleanup. Use NSURL directly where possible.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6934 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-02-21 07:28:48 +00:00
ritsuka
214fed29cd MacGui: refactor the stderr/stdout redirect code to be more modular.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6927 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-02-20 07:59:38 +00:00
ritsuka
44f7f22f2f MacGui: do not make the output panel textview scroll to the bottom if the window is not visible. The scroll operation is expensive.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6923 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-02-18 07:47:23 +00:00
ritsuka
0689343f8d MacGui: refactored some duplicated code.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6728 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-01-11 12:18:49 +00:00
ritsuka
71e4a6fcb9 MacGui: fix a leak of the output log file path string.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6719 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-01-10 08:38:37 +00:00
ritsuka
fefb2423b5 MacGui: use the inline find bar in the activity window.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6691 b64f7644-9d1e-0410-96f1-a4d463321fa5
2015-01-07 07:08:46 +00:00
ritsuka
e85690352f MacGui: fix a bunch of regressions (various crash when in some textfields, encode log going to the wrong directory).
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6676 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-12-30 07:13:07 +00:00
ritsuka
0a865e3d00 MacGui: fixed a warning in HBOutputRedirect and removed an unused ivar.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6488 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-10-31 06:58:45 +00:00
ritsuka
0e165d0a09 MacGui: moved two methods used by the whole app to HBUtilities.m:
- appSupportPath:
- writeToActivityLog:

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@6232 b64f7644-9d1e-0410-96f1-a4d463321fa5
2014-07-16 06:20:57 +00:00
dynaflash
c871247f8f MacGui: Raise the TextStorageUpperSizeLimit and TextStorageLowerSizeLimit x 3 to accomodate larger logs in the activity window. Recommended by BradleyS and approved by me.
- TextStorageUpperSizeLimit 125000
- TextStorageLowerSizeLimit 120000

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@3069 b64f7644-9d1e-0410-96f1-a4d463321fa5
2010-01-13 00:43:05 +00:00
dynaflash
6e73207f49 MacGui: Replace deprecated -createDirectoryAtPath:attributes: with -createDirectoryAtPath:withIntermediateDirectories:attributes:error:
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2828 b64f7644-9d1e-0410-96f1-a4d463321fa5
2009-09-16 15:21:48 +00:00
dynaflash
665406fbd1 MacGui: Change the format for individual activity log file names.
- Put the output file's base name first .... should make searching for logs easier as per lingui.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2625 b64f7644-9d1e-0410-96f1-a4d463321fa5
2009-06-26 14:33:24 +00:00
dynaflash
f3c1572478 MacGui: Fix activity log headers to show correct version when clearing the window as well as the session log.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2472 b64f7644-9d1e-0410-96f1-a4d463321fa5
2009-06-02 20:02:06 +00:00
dynaflash
e71371db07 MacGui: Report the svn version and arch in the session activity log and the individual encode log.
- ie. [11:25:22] macgui: Handbrake Version: svn2207 x86_64 (2009030301)

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2209 b64f7644-9d1e-0410-96f1-a4d463321fa5
2009-03-03 17:26:47 +00:00
dynaflash
f1c3b0a71e MacGui: Picture Filters separate hud inspector initial implementation
- Separates the filters out from the picture settings inspector into their own inspector in preparation for more advanced filters
- Gingerbread is shaky but wanted to get the functionality into the svn due the the number of files modified or added.
- Adds a toggle action to Picture Settings, Picture Filters and the activity window

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2099 b64f7644-9d1e-0410-96f1-a4d463321fa5
2009-01-26 21:34:59 +00:00
dynaflash
1b3278e1c4 MacGui: correct month output in the names of the individual encode logs
- Duh! In struct tm,  tm_mon is the month number from 0 to 11, so we needed to be using tm_mon + 1

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2005 b64f7644-9d1e-0410-96f1-a4d463321fa5
2008-12-04 18:58:03 +00:00
dynaflash
e6ff04ad0b MacGui: Add the svn and build number to the individual encode log headers
- thanks for noticing and reminding me cvk_b.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1920 b64f7644-9d1e-0410-96f1-a4d463321fa5
2008-11-15 18:31:41 +00:00
dynaflash
39a4d09c45 MacGui: Acivity Logs for individual encodes initial implementation
- Individual activity logs are saved in the file format "YYYY-MM-DD HH-MM-SS mymoviename.txt".
- Default directory is "~/Library/Application Support/HandBrake/EncodeLogs/".
- Advanced preference available to alternatively put them in the users output movie directory with the output movie (by default set to "off").
- Renamed the existing contextual menu items for the Activity Window to better reflect choices (function remains the same) as follows:
-- "Copy All Output" -> "Copy Window Contents".
-- "Clear Output" -> "Clear Window Contents".
-- "Open Log File" -> "Open Log File For This Session".
-- "Clear Log File" -> "Clear Log File For This Session".
- Added "Open Individual Log File Directory" to the Activity Window contextual menu to open this directory with the Finder
- Also commented out some macgui based activity log messages that were used to troubleshoot the new queue.
- Note: the individual activity logs are in addition to the existing session based activity log. If you do a scan of a new source during encoding, the new source scan log messages will be intermixed with the encode log messages as I have no clue how to separate stderr/stdout based on which instance of libhb is sending the messages.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1881 b64f7644-9d1e-0410-96f1-a4d463321fa5
2008-10-30 18:11:58 +00:00
ritsuka
ecd08ad8b0 MacGUI: Make HBOutputPanelWindowController an NSWindowController subclass. Patch by blindjimmy.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1458 b64f7644-9d1e-0410-96f1-a4d463321fa5
2008-05-13 11:24:27 +00:00
dynaflash
6449e97629 MacGui: Write version info the the activity log and activity window
- writes the Handbrake version number and build number to the activity window and log text file upon startup (this no longer occured out of libhb once we updated the update system to Sparkle)
- Add writing the version info upon clearing of either the log file or the window, this way we have version info from users even if they have cleared the top of the logs.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1344 b64f7644-9d1e-0410-96f1-a4d463321fa5
2008-03-17 15:09:39 +00:00
dynaflash
374a7b7ef9 MacGui: Activity Log
- Add "Clear Log" to the activity window contextual menu
- Clears the log and prints a new date/time header in the log
- Useful for starting a new log without having to relaunch HB.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1063 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-11-16 13:17:00 +00:00
dynaflash
d5d153eff8 MacGui: Move app support directory check to -init in controller.mm
- Makes ~/Library/Application Support/HandBrake available to HBOutputPanelController immediately
- Elimates duplicate code to check for app support directory for both the presets as well as the activity log (as well as any other future features that will require this directory)
- Also fixed issue where clicking "Discard" in the update alert closes the main window and won't let it come back (this will be totally unnecessary once the Sparkle update system is implemented).

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1061 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-11-15 14:48:16 +00:00
dynaflash
93f4ade648 MacGui: Activity Window Logging Initial Implementation
- stderr and stdout are now written to a .txt file as well as displayed in the activity window
- Each line from stdout and stderr is written as it comes out of libhb (instead of in batches) so that in the event of a crash, we see the very last log message just like in the cli output
- Log file is located at: ~/Library/Application Support/HandBrake/HandBrake-activitylog.txt
- Uses .txt file as .log files default to open in console (text editor is more user friendly to n00bs?).
- For initial implementation, log file is overwritten for each session, and the current date and time is printed at the top of the log. So, log is one session long, for now.
- Activity window is also now a normal window (not an inspector) so that you can minimize it and the picture preview window is not half covered up by it on a smaller (mbp) display
- Added "Open Log File" to the Activity Window contextual menu which opens the log file in the users default text editor

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@1058 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-11-14 16:37:34 +00:00
dynaflash
890d542eb5 MacGui: Increase the Activity Window text storage to double its current capacity for more complete logs.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@855 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-08-23 20:12:02 +00:00
jbrjake
d29ed81645 MacGui: hot scrolling action for the Debug Output logging window. Thanks for the patch, Ritsuka!
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@728 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-07-24 16:39:40 +00:00
cleaner
bdfe89478b Debug output window is now opened automatically if it was visible when HB was closed.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@603 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-06-06 20:05:55 +00:00
cleaner
7ff9af9ced Typo fix and test of commit rights.
git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@598 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-06-05 16:46:30 +00:00
dynaflash
2106d23726 MacGui: Add stdout to the Debug Inspector window
- thanks again to Cleaner

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@596 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-06-04 19:55:45 +00:00
dynaflash
7f232a9f43 MacGui: Debug Window to read libhb output like cli in inspector window
- Thank You Cleaner!!
- Adds Debug Output to Window menu
- Adds Verbose pref to preferences menu
- MacGui now reads output from libhb like cli
- May add pref to open Debug Output window upon launch
- All credit goes to Cleaner, Thank You!

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@592 b64f7644-9d1e-0410-96f1-a4d463321fa5
2007-05-21 16:50:21 +00:00