chore: fix code smells

src/client/api/authentication.js

@@ -16,7 +16,7 @@ export const signIn = async (username, password) => {
         };
     }
 
-    return await data.json();
+    return data.json();
 };
 
 export const signUp = async (email, username, password) => {
@@ -29,7 +29,7 @@ export const signUp = async (email, username, password) => {
         body: JSON.stringify({ email, username, password }),
     });
 
-    return await data.json();
+    return data.json();
 };
 
 export const verify = async (token) => {
@@ -48,5 +48,5 @@ export const verify = async (token) => {
         };
     }
 
-    return await data.json();
+    return data.json();
 };

src/client/api/secret.js

@@ -42,7 +42,7 @@ export const getSecret = async (secretId, password) => {
         };
     }
 
-    return await data.json();
+    return data.json();
 };
 
 export const burnSecret = async (secretId) => {
@@ -51,7 +51,7 @@ export const burnSecret = async (secretId) => {
         cache: 'no-cache',
     });
 
-    return await data.json();
+    return data.json();
 };
 
 export const secretExists = async (secretId) => {
@@ -63,5 +63,5 @@ export const secretExists = async (secretId) => {
         };
     }
 
-    return await data.json();
+    return data.json();
 };

src/client/components/header/index.js

@@ -1,6 +1,5 @@
-import React from 'react';
 import { Link, Redirect } from 'react-router-dom';
-import { useEffect, useState } from 'react';
+import React, { useEffect, useState } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import { Anchor, Button, Container, Group, Grid } from '@mantine/core';
 import { IconLockOff, IconLogin } from '@tabler/icons';

src/client/routes/account/index.js

@@ -1,5 +1,4 @@
-import React from 'react';
+import React, { useEffect, useState } from 'react';
-import { useEffect, useState } from 'react';
 import {
     Container,
     TextInput,

src/client/routes/secret/index.js

@@ -1,5 +1,4 @@
-import React from 'react';
+import React, { useEffect, useState } from 'react';
-import { useEffect, useState } from 'react';
 import { useParams, Link } from 'react-router-dom';
 
 import { Button, Group, Container, Textarea, TextInput, Stack, Title, Text } from '@mantine/core';

src/client/routes/signin/index.js

@@ -1,5 +1,4 @@
-import React from 'react';
+import React, { useEffect, useState } from 'react';
-import { useEffect, useState } from 'react';
 import { Redirect } from 'react-router-dom';
 import { Button, Container, TextInput, Stack, Title, Text, PasswordInput } from '@mantine/core';
 import { IconLock, IconUser, IconLogin } from '@tabler/icons';

src/client/routes/signup/index.js

@@ -1,5 +1,4 @@
-import React from 'react';
+import React, { useEffect, useState } from 'react';
-import { useEffect, useState } from 'react';
 import { Redirect } from 'react-router-dom';
 import { Button, Container, TextInput, Stack, Title, Text, PasswordInput } from '@mantine/core';
 import { IconLock, IconUser, IconLogin, IconAt } from '@tabler/icons';

src/server/services/redis.js

@@ -103,11 +103,7 @@ export async function keyExists(key) {
 }
 
 export async function isAlive() {
-    if ((await client.ping()) === 'PONG') {
+    return (await client.ping()) === 'PONG';
-        return true;
-    }
-
-    return false;
 }
 
 export async function createUser(username, email, password) {
@@ -155,11 +151,7 @@ export async function createRateLimit(ip) {
             });
     });
 
-    if (increments > DEFAULT_RATE_LIMIT_QTY) {
+    return increments > DEFAULT_RATE_LIMIT_QTY;
-        return true;
-    }
-
-    return false;
 }
 
 export async function createStatistics(type = '') {