1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Bug #22860: Option --memlock should be revisited

Browse Source 
Support says that memlock doesn't work on OSes other than Solaris.  
Add a warning about --memlock to the crash monologue.


sql/mysqld.cc:
  On a crash when --memlock was active, emit advice about the insta-
  bility of that parameter.
This commit is contained in:
unknown 2006-11-10 16:36:08 -05:00
parent 02e764bd10
commit 93e1030ddd
2 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BitKeeper/etc/collapsed
View File

@ -1,3 +1,5 @@
452a92d0-31-8wSzSfZi165fcGcXPA 452a92d0-31-8wSzSfZi165fcGcXPA
454a7ef8gdvE_ddMlJyghvOAkKPNOQ 454a7ef8gdvE_ddMlJyghvOAkKPNOQ
454f8960jsVT_kMKJtZ9OCgXoba0xQ 454f8960jsVT_kMKJtZ9OCgXoba0xQ
4554a95d7txO1DuO9G3nAizI3SkFAA
4554b3722d71SbPiI2Gx-RhbZjmuIQ

27
sql/mysqld.cc
View File

@ -274,7 +274,7 @@ bool opt_disable_networking=0, opt_skip_show_db=0;
bool opt_character_set_client_handshake= 1; bool opt_character_set_client_handshake= 1;
bool lower_case_table_names_used= 0; bool lower_case_table_names_used= 0;
bool server_id_supplied = 0; bool server_id_supplied = 0;
bool opt_endinfo,using_udf_functions, locked_in_memory; bool opt_endinfo, using_udf_functions, locked_in_memory;
bool opt_using_transactions, using_update_log; bool opt_using_transactions, using_update_log;
bool volatile abort_loop, select_thread_in_use, signal_thread_in_use; bool volatile abort_loop, select_thread_in_use, signal_thread_in_use;
bool volatile ready_to_exit, shutdown_in_progress, grant_option; bool volatile ready_to_exit, shutdown_in_progress, grant_option;
@ -2015,13 +2015,24 @@ later when used with nscd), disable LDAP in your nsswitch.conf, or use a\n\
mysqld that is not statically linked.\n"); mysqld that is not statically linked.\n");
#endif #endif
if (test_flags & TEST_CORE_ON_SIGNAL) if (locked_in_memory)
{ {
fprintf(stderr, "Writing a core file\n"); fprintf(stderr, "\n\
fflush(stderr); The \"--memlock\" argument, which was enabled, uses system calls that are\n\
write_core(sig); unreliable and unstable on some operating systems and operating-system\n\
} versions (notably, some versions of Linux). This crash could be due to use\n\
exit(1); of those buggy OS calls. You should consider whether you really need the\n\
\"--memlock\" parameter and/or consult the OS distributer about \"mlockall\"\n\
bugs.\n");
}
if (test_flags & TEST_CORE_ON_SIGNAL)
{
fprintf(stderr, "Writing a core file\n");
fflush(stderr);
write_core(sig);
}
exit(1);
} }
#ifndef SA_RESETHAND #ifndef SA_RESETHAND