1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MDEV-34533 post-fix

Browse Source 
Cache results of expensive my_get_stack_bounds(), instead of calling
it for every query in thread_attach()

See MDEV-27943 for effort to reduce thread_attach() overhead
This commit is contained in:
Vladislav Vaintroub 2024-11-05 18:12:05 +01:00
parent 37b7986467
commit a2a0adbfc3
1 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sql/threadpool_common.cc
View File

@ -154,13 +154,13 @@ static inline void set_thd_idle(THD *thd)
*/ */
struct OS_thread_info struct OS_thread_info
{ {
void *stack_start;
void *stack_end;
pthread_t self; pthread_t self;
ssize_t stack_size;
uint32_t thread_id; uint32_t thread_id;
inline bool initialized() { return stack_start != 0; }
inline bool initialized() { return stack_size != 0; } void init()
void init(ssize_t ssize)
{ {
#if _WIN32 #if _WIN32
self= thread_id= GetCurrentThreadId(); self= thread_id= GetCurrentThreadId();
@ -172,7 +172,10 @@ struct OS_thread_info
#endif #endif
self= pthread_self(); self= pthread_self();
#endif #endif
stack_size= ssize; char stack_var;
my_get_stack_bounds(&stack_start, &stack_end, &stack_var, my_thread_stack_size);
DBUG_ASSERT(stack_start);
DBUG_ASSERT(stack_end);
} }
}; };
static thread_local OS_thread_info os_thread_info; static thread_local OS_thread_info os_thread_info;
@ -181,7 +184,7 @@ static const OS_thread_info *get_os_thread_info()
{ {
auto *res= &os_thread_info; auto *res= &os_thread_info;
if (!res->initialized()) if (!res->initialized())
res->init((ssize_t) (my_thread_stack_size * STACK_DIRECTION)); res->init();
return res; return res;
} }
@ -199,8 +202,8 @@ static void thread_attach(THD* thd)
const OS_thread_info *tinfo= get_os_thread_info(); const OS_thread_info *tinfo= get_os_thread_info();
set_current_thd(thd); set_current_thd(thd);
my_get_stack_bounds(&thd->thread_stack, &thd->mysys_var->stack_ends_here, thd->thread_stack= tinfo->stack_start;
(void*) &tinfo, my_thread_stack_size); thd->mysys_var->stack_ends_here= tinfo->stack_end;
thd->real_id= tinfo->self; thd->real_id= tinfo->self;
thd->os_thread_id= tinfo->thread_id; thd->os_thread_id= tinfo->thread_id;
PSI_CALL_set_thread(thd->get_psi()); PSI_CALL_set_thread(thd->get_psi());