1berry/MariaDB-server
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
MariaDB-server/mysql-test/suite/versioning/t/delete_history.test
Aleksey Midenkov f1f9284181 MDEV-34046 Parameterized PS converts error to warning, causes 
replication problems

DELETE HISTORY did not process parameterized PS properly as the
history expression was checked on prepare stage when the parameters
was not yet substituted. In that case check_units() succeeded as there
is no invalid type: Item_param has type_handler_null which is
inherited from string type and this is valid type for history
expression. The warning was thrown when the expression was evaluated
for comparison on delete execution (when the parameter was already
substituted).

The fix postpones check_units() until the first PS execution. We have
to postpone where conditions processing until the first execution and
update select_lex.where on every execution as it is reset to the state
after prepare.
2025-06-12 14:52:00 +03:00

358 lines
12 KiB
Plaintext
Raw Blame History

--source suite/versioning/common.inc
--source include/have_partition.inc
--source suite/versioning/engines.inc
call mtr.add_suppression("need more HISTORY partitions");
create table t (a int);
--error ER_VERS_NOT_VERSIONED
delete history from t before system_time now();
# TRUNCATE is not DELETE and trigger must not be called.
--replace_result $sys_datatype_expl SYS_TYPE
eval create or replace table t (
a int,
row_start $sys_datatype_expl as row start invisible,
row_end $sys_datatype_expl as row end invisible,
period for system_time (row_start, row_end))
with system versioning;
insert into t values (1);
update t set a=2;
set @test = 'correct';
create trigger trg_before before delete on t for each row set @test = 'incorrect';
create trigger trg_after after delete on t for each row set @test = 'incorrect';
delete history from t;
select @test from t;
drop table t;
--replace_result $sys_datatype_expl SYS_TYPE
eval create or replace table t (
a int,
row_start $sys_datatype_expl as row start invisible,
row_end $sys_datatype_expl as row end invisible,
period for system_time (row_start, row_end))
with system versioning;
insert into t values (1), (2);
update t set a=11 where a=1;
--real_sleep 0.01
set @ts1=now(6);
--real_sleep 0.01
update t set a=22 where a=2;
select * from t for system_time all;
delete history from t before system_time timestamp @ts1;
select * from t for system_time all;
prepare stmt from 'delete history from t';
execute stmt; drop prepare stmt;
select * from t for system_time all;
delete from t;
delimiter ~~;
create or replace procedure truncate_sp()
begin
delete history from t before system_time timestamp now(6);
end~~
delimiter ;~~
call truncate_sp;
select * from t for system_time all;
drop procedure truncate_sp;
--echo # Truncate partitioned
create or replace table t (a int) with system versioning
partition by system_time limit 1 partitions 3;
insert into t values (1);
update t set a= 2;
update t set a= 3;
--echo # You see warning above ^
delete history from t;
select * from t for system_time all;
--echo # VIEW
--replace_result $sys_datatype_expl SYS_TYPE
eval create or replace table t (
i int,
row_start $sys_datatype_expl as row start invisible,
row_end $sys_datatype_expl as row end invisible,
period for system_time (row_start, row_end))
with system versioning;
delete history from t;
create or replace view v as select * from t;
--error ER_IT_IS_A_VIEW
delete history from v;
create or replace table t (i int);
--error ER_VERS_NOT_VERSIONED
delete history from t;
create or replace view v as select * from t;
--error ER_IT_IS_A_VIEW
delete history from v;
--error ER_VERS_NOT_VERSIONED
prepare stmt from 'delete history from t';
drop table t;
drop view v;
#
# MDEV-15402 Assertion `table' failed in mysql_delete on attempt to delete history from view
#
create or replace table t (i int);
create or replace view v as select * from t;
--error ER_IT_IS_A_VIEW
drop table v;
lock table v write;
--error ER_IT_IS_A_VIEW
delete history from v before system_time now(6);
unlock tables;
drop view v;
drop table t;
#
# MDEV-16783 Assertion `!conds' failed in mysql_delete upon 2nd execution of SP with DELETE HISTORY
#
create table t1 (i int) with system versioning;
create procedure pr() delete history from t1 before system_time now();
call pr;
call pr;
drop procedure pr;
drop table t1;
--echo # MDEV-15966 Behavior for TRUNCATE versioned table is not documented and not covered by tests
create or replace table t1 (id int);
create or replace table t2 (id int) with system versioning;
-- echo # force cleaning table shares
flush tables t1, t2;
truncate table t1;
--error ER_VERS_NOT_SUPPORTED
truncate table t2;
-- echo # fetch table shares
describe t1;
describe t2;
truncate table t1;
--error ER_VERS_NOT_SUPPORTED
truncate table t2;
--echo # enter locked tables mode
lock tables t1 WRITE, t2 WRITE;
truncate t1;
--error ER_VERS_NOT_SUPPORTED
truncate t2;
unlock tables;
drop table t2;
--echo #
--echo # MDEV-19814 Assertion `update->n_fields < ulint(table->n_cols + table->n_v_cols)' on DELETE HISTORY
--echo #
--replace_result $sys_datatype_expl SYS_TYPE
eval create or replace table t1 (
f varchar(1),
row_start $sys_datatype_expl as row start,
row_end $sys_datatype_expl as row end,
period for system_time (row_start, row_end))
with system versioning;
insert into t1 (f) values ('a'), ('b'), ('c'), ('d'), ('e'), ('f'), ('g'), ('h');
delete from t1;
delete history from t1;
drop table t1;
--echo #
--echo # MDEV-20186 Wrong result or Assertion on INSERT after DELETE HISTORY
--echo #
create or replace table t1 (a int check (a > 0)) with system versioning;
delete history from t1;
insert into t1 values (1);
select * from t1;
drop table t1;
--echo #
--echo # MDEV-25468 DELETE HISTORY may delete current data on system-versioned table
--echo #
create or replace table t1 (x int) with system versioning;
insert into t1 values (1);
delete history from t1 before system_time '2039-01-01 23:00';
select * from t1;
explain extended delete history from t1 before system_time '2039-01-01 23:00';
create or replace procedure p() delete history from t1 before system_time '2039-01-01 23:00';
call p;
select * from t1;
call p;
select * from t1;
drop procedure p;
prepare stmt from "delete history from t1 before system_time '2039-01-01 23:00'";
execute stmt;
select * from t1;
execute stmt;
select * from t1;
drop prepare stmt;
drop table t1;
--echo #
--echo # MDEV-25004 Missing row in FTS_DOC_ID_INDEX during DELETE HISTORY
--echo #
create table t1 (a integer, c0 varchar(255), fulltext key (c0))
with system versioning engine innodb stats_persistent=0;
set system_versioning_alter_history= keep;
alter table t1 drop system versioning;
alter table t1 add system versioning;
insert into t1 values (1, 'politician');
update t1 set c0= 'criminal';
--source suite/innodb/include/wait_all_purged.inc
delete history from t1;
drop table t1;
create table t1 (id int primary key, ftx varchar(255))
with system versioning engine innodb stats_persistent=0;
insert into t1 values (1, 'c');
delete from t1;
alter table t1 add fulltext key(ftx);
drop table t1;
--echo #
--echo # MDEV-28201 Server crashes upon SHOW ANALYZE/EXPLAIN FORMAT=JSON
--echo #
CREATE TABLE t1 (a INT) WITH SYSTEM VERSIONING;
CREATE ALGORITHM=TEMPTABLE VIEW v1 AS SELECT * FROM t1;
SET optimizer_trace= 'enabled=on';
--error ER_NON_UPDATABLE_TABLE
DELETE HISTORY FROM v1 BEFORE SYSTEM_TIME '2021-01-01';
--error ER_NON_UPDATABLE_TABLE
DELETE HISTORY FROM v1;
DROP VIEW v1;
DROP TABLE t1;
--echo # End of 10.4 tests
--echo #
--echo # MDEV-33470 Unique hash index is broken on DML for system-versioned table
--echo #
create or replace table t (
c int, unique (c) using hash)
with system versioning;
insert into t values (0);
delete from t;
delete history from t;
drop table t;
--echo # End of 10.5 tests
--echo #
--echo # MDEV-17554 Auto-create new partition for system versioned tables with history partitioned by INTERVAL/LIMIT
--echo #
--echo # Don't auto-create new partition on DELETE HISTORY:
set timestamp= unix_timestamp('2000-01-01 00:00:00');
create or replace table t (a int) with system versioning
partition by system_time interval 1 hour auto;
set timestamp= unix_timestamp('2000-01-01 10:00:00');
delete history from t;
set timestamp= default;
--replace_result $default_engine DEFAULT_ENGINE
show create table t;
drop table t;
--echo # End of 10.9 tests
--echo #
--echo # MDEV-34046 Parameterized PS converts error to warning, causes replication problems
--echo #
create table t (a int) with system versioning;
set timestamp= unix_timestamp('2000-01-01 00:00:00');
insert into t values (1), (100);
--error ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION
delete history from t before system_time @@timestamp;
--error ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION
execute immediate "delete history from t before system_time @@timestamp";
--error ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION
execute immediate "delete history from t before system_time ?" using @@timestamp;
set @ts1= '2000-01-01 00:00:01'; set timestamp= unix_timestamp(@ts1);
update t set a= a + 1 where a < 100;
set @ts2= '2000-01-01 00:00:02'; set timestamp= unix_timestamp(@ts2);
update t set a= a + 1 where a < 100;
set @ts3= '2000-01-01 00:00:03'; set timestamp= unix_timestamp(@ts3);
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time @ts1";
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time @ts2";
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time ?" using @ts3;
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time ?" using @ts3;
select *, row_start, row_end from t for system_time all order by a;
update t set a= a + 1 where a < 100;
set @ts4= '2000-01-01 00:00:04'; set timestamp= unix_timestamp(@ts4);
update t set a= a + 1 where a < 100;
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time ?" using '2000-01-01 00:00:04';
select *, row_start, row_end from t for system_time all order by a;
set @ts5= '2000-01-01 00:00:05'; set timestamp= unix_timestamp(@ts5);
update t set a= a + 1 where a < 100;
set @ts6= '2000-01-01 00:00:06'; set timestamp= unix_timestamp(@ts6);
update t set a= a + 1 where a < 100;
set @ts7= '2000-01-01 00:00:07'; set timestamp= unix_timestamp(@ts7);
update t set a= a + 1 where a < 100;
select *, row_start, row_end from t for system_time all order by a;
prepare stmt from 'delete history from t before system_time ?';
execute stmt using @ts4;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts5;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts6;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using '2000-01-01 00:00:06';
select *, row_start, row_end from t for system_time all order by a;
execute stmt using '2000-01-01 00:00:06.000001';
select *, row_start, row_end from t for system_time all order by a;
set @ts8= '2000-01-01 00:00:08'; set timestamp= unix_timestamp(@ts8);
delete from t;
select *, row_start, row_end from t for system_time all order by a;
execute immediate "delete history from t before system_time from_unixtime(?)" using @@timestamp;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using '2020-01-01';
select *, row_start, row_end from t for system_time all order by a;
drop prepare stmt;
# Check expression
set timestamp= unix_timestamp('2000-01-01 00:00:00');
insert into t values (1), (100);
set @ts1= '2000-01-01 00:00:01'; set timestamp= unix_timestamp(@ts1);
update t set a= a + 1 where a < 100;
set timestamp= @@timestamp + 1;
set @ts2= @@timestamp;
update t set a= a + 1 where a < 100;
set timestamp= @@timestamp + 1;
update t set a= a + 1 where a < 100;
prepare stmt from 'delete history from t before system_time from_unixtime(? + ?)';
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts1, 0;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts2, 0;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @@timestamp, NULL;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using NULL, NULL;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts2, 1;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts2, @ts2;
select *, row_start, row_end from t for system_time all order by a;
delete from t;
select *, row_start, row_end from t for system_time all order by a;
execute stmt using @ts2, @ts2;
select *, row_start, row_end from t for system_time all order by a;
drop prepare stmt;
drop table t;
set timestamp= default;
--echo # End of 10.11 tests
--source suite/versioning/common_finish.inc
Reference in New Issue View Git Blame Copy Permalink