1berry/blender
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix #122276: Crash when searching for a Collection Instance

Browse Source 
This search menu creation/refreshing function relies on the operator
pointer which might be dangling. There are more such cases, will fix in
followup commits.
This commit is contained in:
Julian Eisel 2024-05-27 20:58:12 +02:00
parent 8542797c6f
commit 8ea79dc3a7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/blender/windowmanager/intern/wm_operators.cc
View File

@ -1149,7 +1149,9 @@ int WM_enum_search_invoke(bContext *C, wmOperator *op, const wmEvent * /*event*/
{ {
static EnumSearchMenu search_menu; static EnumSearchMenu search_menu;
search_menu.op = op; search_menu.op = op;
UI_popup_block_invoke(C, wm_enum_search_menu, &search_menu, nullptr); /* Refreshing not supported, because operator might get freed. */
const bool can_refresh = false;
UI_popup_block_invoke_ex(C, wm_enum_search_menu, &search_menu, nullptr, can_refresh);
return OPERATOR_INTERFACE; return OPERATOR_INTERFACE;
} }