a7ab81d927
BaseException was used as a catch-all in situations where it didn't make sense and where "Exception" is more appropriate based on Python's documentation & error checking tools, `pylint` warns `broad-exception-caught` for e.g. BaseException includes SystemExit, KeyboardInterrupt & GeneratorExit, so unless the intention is to catch calls to `sys.exit(..)`, breaking a out of a loop using Ctrl-C or generator-exit, then it shouldn't be used. Even then, it's preferable to catch those exceptions explicitly.
55 lines
1.6 KiB
Python
55 lines
1.6 KiB
Python
# SPDX-FileCopyrightText: 2023 Blender Authors
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
__all__ = (
|
|
"open_external_editor",
|
|
)
|
|
|
|
|
|
def open_external_editor(filepath, line, column, /):
|
|
# Internal Python implementation for `TEXT_OT_jump_to_file_at_point`.
|
|
# Returning a non-empty string represents an error, an empty string for success.
|
|
import shlex
|
|
import subprocess
|
|
from string import Template
|
|
from bpy import context
|
|
from bpy.app.translations import pgettext_rpt as rpt_
|
|
|
|
text_editor = context.preferences.filepaths.text_editor
|
|
text_editor_args = context.preferences.filepaths.text_editor_args
|
|
|
|
# The caller should check this.
|
|
assert text_editor
|
|
|
|
if not text_editor_args:
|
|
return rpt_(
|
|
"Provide text editor argument format in File Paths/Applications Preferences, "
|
|
"see input field tool-tip for more information",
|
|
)
|
|
|
|
if "$filepath" not in text_editor_args:
|
|
return rpt_("Text Editor Args Format must contain $filepath")
|
|
|
|
args = [text_editor]
|
|
template_vars = {
|
|
"filepath": filepath,
|
|
"line": line + 1,
|
|
"column": column + 1,
|
|
"line0": line,
|
|
"column0": column,
|
|
}
|
|
|
|
try:
|
|
args.extend([Template(arg).substitute(**template_vars) for arg in shlex.split(text_editor_args)])
|
|
except Exception as ex:
|
|
return rpt_("Exception parsing template: {!r}").format(ex)
|
|
|
|
try:
|
|
# With `check=True` if `process.returncode != 0` an exception will be raised.
|
|
subprocess.run(args, check=True)
|
|
except Exception as ex:
|
|
return rpt_("Exception running external editor: {!r}").format(ex)
|
|
|
|
return ""
|