1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Tests versus zero are more compact than tests versus -1.

Browse Source
This commit is contained in:
Raymond Hettinger 2016-01-25 10:33:30 -08:00
parent 1ce6885f8a
commit 0dceb91866
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Objects/listobject.c
View File

@ -248,7 +248,7 @@ ins1(PyListObject *self, Py_ssize_t where, PyObject *v)
return -1; return -1;
} }
if (list_resize(self, n+1) == -1) if (list_resize(self, n+1) < 0)
return -1; return -1;
if (where < 0) { if (where < 0) {
@ -288,7 +288,7 @@ app1(PyListObject *self, PyObject *v)
return -1; return -1;
} }
if (list_resize(self, n+1) == -1) if (list_resize(self, n+1) < 0)
return -1; return -1;
Py_INCREF(v); Py_INCREF(v);
@ -708,7 +708,7 @@ list_inplace_repeat(PyListObject *self, Py_ssize_t n)
return PyErr_NoMemory(); return PyErr_NoMemory();
} }
if (list_resize(self, size*n) == -1) if (list_resize(self, size*n) < 0)
return NULL; return NULL;
p = size; p = size;
@ -798,7 +798,7 @@ listextend(PyListObject *self, PyObject *b)
Py_RETURN_NONE; Py_RETURN_NONE;
} }
m = Py_SIZE(self); m = Py_SIZE(self);
if (list_resize(self, m + n) == -1) { if (list_resize(self, m + n) < 0) {
Py_DECREF(b); Py_DECREF(b);
return NULL; return NULL;
} }
@ -826,7 +826,7 @@ listextend(PyListObject *self, PyObject *b)
/* Guess a result list size. */ /* Guess a result list size. */
n = PyObject_LengthHint(b, 8); n = PyObject_LengthHint(b, 8);
if (n == -1) { if (n < 0) {
Py_DECREF(it); Py_DECREF(it);
return NULL; return NULL;
} }
@ -834,7 +834,7 @@ listextend(PyListObject *self, PyObject *b)
mn = m + n; mn = m + n;
if (mn >= m) { if (mn >= m) {
/* Make room. */ /* Make room. */
if (list_resize(self, mn) == -1) if (list_resize(self, mn) < 0)
goto error; goto error;
/* Make the list sane again. */ /* Make the list sane again. */
Py_SIZE(self) = m; Py_SIZE(self) = m;