1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Issue #10838: Run test__all__() everywhere, even if poll() is not available

Browse Source
This commit is contained in:
Martin Panter 2016-04-16 11:28:10 +00:00
parent 119e502277
commit 23172bd47b
1 changed files with 14 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Lib/test/test_subprocess.py
View File

@ -2518,7 +2518,7 @@ class Win32ProcessTestCase(BaseTestCase):
def test_terminate_dead(self): def test_terminate_dead(self):
self._kill_dead_process('terminate') self._kill_dead_process('terminate')
class CommandTests(unittest.TestCase): class MiscTests(unittest.TestCase):
def test_getoutput(self): def test_getoutput(self):
self.assertEqual(subprocess.getoutput('echo xyzzy'), 'xyzzy') self.assertEqual(subprocess.getoutput('echo xyzzy'), 'xyzzy')
self.assertEqual(subprocess.getstatusoutput('echo xyzzy'), self.assertEqual(subprocess.getstatusoutput('echo xyzzy'),
@ -2538,19 +2538,6 @@ class CommandTests(unittest.TestCase):
if dir is not None: if dir is not None:
os.rmdir(dir) os.rmdir(dir)
@unittest.skipUnless(hasattr(selectors, 'PollSelector'),
"Test needs selectors.PollSelector")
class ProcessTestCaseNoPoll(ProcessTestCase):
def setUp(self):
self.orig_selector = subprocess._PopenSelector
subprocess._PopenSelector = selectors.SelectSelector
ProcessTestCase.setUp(self)
def tearDown(self):
subprocess._PopenSelector = self.orig_selector
ProcessTestCase.tearDown(self)
def test__all__(self): def test__all__(self):
"""Ensure that __all__ is populated properly.""" """Ensure that __all__ is populated properly."""
intentionally_excluded = set(("list2cmdline",)) intentionally_excluded = set(("list2cmdline",))
@ -2566,6 +2553,18 @@ class ProcessTestCaseNoPoll(ProcessTestCase):
self.assertEqual(exported, possible_exports - intentionally_excluded) self.assertEqual(exported, possible_exports - intentionally_excluded)
@unittest.skipUnless(hasattr(selectors, 'PollSelector'),
"Test needs selectors.PollSelector")
class ProcessTestCaseNoPoll(ProcessTestCase):
def setUp(self):
self.orig_selector = subprocess._PopenSelector
subprocess._PopenSelector = selectors.SelectSelector
ProcessTestCase.setUp(self)
def tearDown(self):
subprocess._PopenSelector = self.orig_selector
ProcessTestCase.tearDown(self)
@unittest.skipUnless(mswindows, "Windows-specific tests") @unittest.skipUnless(mswindows, "Windows-specific tests")
class CommandsWithSpaces (BaseTestCase): class CommandsWithSpaces (BaseTestCase):
@ -2669,7 +2668,7 @@ def test_main():
unit_tests = (ProcessTestCase, unit_tests = (ProcessTestCase,
POSIXProcessTestCase, POSIXProcessTestCase,
Win32ProcessTestCase, Win32ProcessTestCase,
CommandTests, MiscTests,
ProcessTestCaseNoPoll, ProcessTestCaseNoPoll,
CommandsWithSpaces, CommandsWithSpaces,
ContextManagerTests, ContextManagerTests,