1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-41793: Fix an inaccuracy about reflected methods in datamodel docs (GH-22257)

Browse Source 
* Qualifying that the right operand's type must be a *strict* subclass for the reflected method to take precedence avoids an edge case / counter-example when the types are actually equal.

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This commit is contained in:
Wim Jeantine-Glenn 2024-10-29 18:02:27 -05:00 committed by GitHub
parent 5527c4051c
commit 298e041631
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
Doc/reference/datamodel.rst
View File

@ -3334,12 +3334,13 @@ left undefined.
These methods are called to implement the binary arithmetic operations These methods are called to implement the binary arithmetic operations
(``+``, ``-``, ``*``, ``@``, ``/``, ``//``, ``%``, :func:`divmod`, (``+``, ``-``, ``*``, ``@``, ``/``, ``//``, ``%``, :func:`divmod`,
:func:`pow`, ``**``, ``<<``, ``>>``, ``&``, ``^``, ``|``) with reflected :func:`pow`, ``**``, ``<<``, ``>>``, ``&``, ``^``, ``|``) with reflected
(swapped) operands. These functions are only called if the left operand does (swapped) operands. These functions are only called if the operands
not support the corresponding operation [#]_ and the operands are of different are of different types, when the left operand does not support the corresponding
types. [#]_ For instance, to evaluate the expression ``x - y``, where *y* is operation [#]_, or the right operand's class is derived from the left operand's
an instance of a class that has an :meth:`__rsub__` method, class. [#]_ For instance, to evaluate the expression ``x - y``, where *y* is
``type(y).__rsub__(y, x)`` is called if ``type(x).__sub__(x, y)`` returns an instance of a class that has an :meth:`__rsub__` method, ``type(y).__rsub__(y, x)``
:data:`NotImplemented`. is called if ``type(x).__sub__(x, y)`` returns :data:`NotImplemented` or ``type(y)``
is a subclass of ``type(x)``. [#]_
.. index:: pair: built-in function; pow .. index:: pair: built-in function; pow
@ -3354,7 +3355,6 @@ left undefined.
non-reflected method. This behavior allows subclasses to override their non-reflected method. This behavior allows subclasses to override their
ancestors' operations. ancestors' operations.
.. method:: object.__iadd__(self, other) .. method:: object.__iadd__(self, other)
object.__isub__(self, other) object.__isub__(self, other)
object.__imul__(self, other) object.__imul__(self, other)
@ -3881,7 +3881,10 @@ An example of an asynchronous context manager class::
method—that will instead have the opposite effect of explicitly method—that will instead have the opposite effect of explicitly
*blocking* such fallback. *blocking* such fallback.
.. [#] For operands of the same type, it is assumed that if the non-reflected .. [#] For operands of the same type, it is assumed that if the non-reflected method
method -- such as :meth:`~object.__add__` -- fails then the overall (such as :meth:`~object.__add__`) fails then the operation is not supported, which is why the
operation is not reflected method is not called.
supported, which is why the reflected method is not called.
.. [#] If the right operand's type is a subclass of the left operand's type, the
reflected method having precedence allows subclasses to override their ancestors'
operations.