1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-33623: Fix possible SIGSGV when asyncio.Future is created in __del__ (#7080)

Browse Source
This commit is contained in:
Yury Selivanov 2018-05-28 11:11:31 -04:00 committed by GitHub
parent 08c5aca9d1
commit 35230d08e0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Misc/NEWS.d/next/Library/2018-05-23-14-58-05.bpo-33623.wAw1cF.rst Normal file
View File

@ -0,0 +1 @@
Fix possible SIGSGV when asyncio.Future is created in __del__

8
Modules/_asynciomodule.c
View File

@ -501,7 +501,13 @@ future_init(FutureObj *fut, PyObject *loop)
if (is_true < 0) { if (is_true < 0) {
return -1; return -1;
} }
if (is_true) { if (is_true && !_Py_IsFinalizing()) {
/* Only try to capture the traceback if the interpreter is not being
finalized. The original motivation to add a `_Py_IsFinalizing()`
call was to prevent SIGSEGV when a Future is created in a __del__
method, which is called during the interpreter shutdown and the
traceback module is already unloaded.
*/
fut->fut_source_tb = _PyObject_CallNoArg(traceback_extract_stack); fut->fut_source_tb = _PyObject_CallNoArg(traceback_extract_stack);
if (fut->fut_source_tb == NULL) { if (fut->fut_source_tb == NULL) {
return -1; return -1;