1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gh-130396: Fix thread sanitizer crashes on stack overflow tests (gh-130966)

Browse Source 
Thread sanitizer will often crash if a test uses more than half the
stack.
This commit is contained in:
Sam Gross 2025-03-11 10:33:23 -04:00 committed by GitHub
parent 1908115871
commit 4162bc133b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Python/ceval.c
View File

@ -392,7 +392,12 @@ _Py_InitializeRecursionLimits(PyThreadState *tstate)
if (err == 0) { if (err == 0) {
uintptr_t base = ((uintptr_t)stack_addr) + guard_size; uintptr_t base = ((uintptr_t)stack_addr) + guard_size;
_tstate->c_stack_top = base + stack_size; _tstate->c_stack_top = base + stack_size;
#ifdef _Py_THREAD_SANITIZER
// Thread sanitizer crashes if we use a bit more than half the stack.
_tstate->c_stack_soft_limit = base + (stack_size / 2);
#else
_tstate->c_stack_soft_limit = base + PYOS_STACK_MARGIN_BYTES * 2; _tstate->c_stack_soft_limit = base + PYOS_STACK_MARGIN_BYTES * 2;
#endif
_tstate->c_stack_hard_limit = base + PYOS_STACK_MARGIN_BYTES; _tstate->c_stack_hard_limit = base + PYOS_STACK_MARGIN_BYTES;
assert(_tstate->c_stack_soft_limit < here_addr); assert(_tstate->c_stack_soft_limit < here_addr);
assert(here_addr < _tstate->c_stack_top); assert(here_addr < _tstate->c_stack_top);