1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

GH-119866: Don't clear frame->stackpointer on release builds (GH-131750)

Browse Source
This commit is contained in:
Brandt Bucher 2025-03-26 12:00:16 -07:00 committed by GitHub
parent 2c686a9ac2
commit 4b3d5b6042
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Include/internal/pycore_interpframe.h
View File

@ -163,15 +163,17 @@ _PyFrame_GetLocalsArray(_PyInterpreterFrame *frame)
return frame->localsplus; return frame->localsplus;
} }
/* Fetches the stack pointer, and sets stackpointer to NULL. // Fetches the stack pointer, and (on debug builds) sets stackpointer to NULL.
Having stackpointer == NULL ensures that invalid // Having stackpointer == NULL makes it easier to catch missing stack pointer
values are not visible to the cycle GC. */ // spills/restores (which could expose invalid values to the GC) using asserts.
static inline _PyStackRef* static inline _PyStackRef*
_PyFrame_GetStackPointer(_PyInterpreterFrame *frame) _PyFrame_GetStackPointer(_PyInterpreterFrame *frame)
{ {
assert(frame->stackpointer != NULL); assert(frame->stackpointer != NULL);
_PyStackRef *sp = frame->stackpointer; _PyStackRef *sp = frame->stackpointer;
#ifndef NDEBUG
frame->stackpointer = NULL; frame->stackpointer = NULL;
#endif
return sp; return sp;
} }