1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid name clash with posix_close (closes #20594)

Browse Source
This commit is contained in:
Benjamin Peterson 2014-02-11 10:16:16 -05:00
parent 3a308b9f37
commit 932bba33f2
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS
View File

@ -20,6 +20,8 @@ Core and Builtins
Library Library
------- -------
- Issue #20594: Avoid name clash with the libc function posix_close.
- Issue #19856: shutil.move() failed to move a directory to other directory - Issue #19856: shutil.move() failed to move a directory to other directory
on Windows if source name ends with os.altsep. on Windows if source name ends with os.altsep.

8
Modules/posixmodule.c
View File

@ -7844,8 +7844,12 @@ PyDoc_STRVAR(posix_close__doc__,
"close(fd)\n\n\ "close(fd)\n\n\
Close a file descriptor (for low level IO)."); Close a file descriptor (for low level IO).");
/*
The underscore at end of function name avoids a name clash with the libc
function posix_close.
*/
static PyObject * static PyObject *
posix_close(PyObject *self, PyObject *args) posix_close_(PyObject *self, PyObject *args)
{ {
int fd, res; int fd, res;
if (!PyArg_ParseTuple(args, "i:close", &fd)) if (!PyArg_ParseTuple(args, "i:close", &fd))
@ -11261,7 +11265,7 @@ static PyMethodDef posix_methods[] = {
{"open", (PyCFunction)posix_open,\ {"open", (PyCFunction)posix_open,\
METH_VARARGS | METH_KEYWORDS, METH_VARARGS | METH_KEYWORDS,
posix_open__doc__}, posix_open__doc__},
{"close", posix_close, METH_VARARGS, posix_close__doc__}, {"close", posix_close_, METH_VARARGS, posix_close__doc__},
{"closerange", posix_closerange, METH_VARARGS, posix_closerange__doc__}, {"closerange", posix_closerange, METH_VARARGS, posix_closerange__doc__},
{"device_encoding", device_encoding, METH_VARARGS, device_encoding__doc__}, {"device_encoding", device_encoding, METH_VARARGS, device_encoding__doc__},
{"dup", posix_dup, METH_VARARGS, posix_dup__doc__}, {"dup", posix_dup, METH_VARARGS, posix_dup__doc__},