1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-26762: _test_multiprocessing reports dangling (#3064)

Browse Source 
_test_multiprocessing now marks the test as ENV_CHANGED on dangling
process or thread.
This commit is contained in:
Victor Stinner 2017-08-10 17:36:50 +02:00 committed by GitHub
parent b97d99cd7f
commit 957d0e9b59
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Lib/test/_test_multiprocessing.py
View File

@ -4329,12 +4329,14 @@ class BaseMixin(object):
processes = set(multiprocessing.process._dangling) - set(cls.dangling[0]) processes = set(multiprocessing.process._dangling) - set(cls.dangling[0])
if processes: if processes:
test.support.environment_altered = True
print('Warning -- Dangling processes: %s' % processes, print('Warning -- Dangling processes: %s' % processes,
file=sys.stderr) file=sys.stderr)
processes = None processes = None
threads = set(threading._dangling) - set(cls.dangling[1]) threads = set(threading._dangling) - set(cls.dangling[1])
if threads: if threads:
test.support.environment_altered = True
print('Warning -- Dangling threads: %s' % threads, print('Warning -- Dangling threads: %s' % threads,
file=sys.stderr) file=sys.stderr)
threads = None threads = None
@ -4402,6 +4404,7 @@ class ManagerMixin(BaseMixin):
t *= 2 t *= 2
dt = time.monotonic() - start_time dt = time.monotonic() - start_time
if dt >= 5.0: if dt >= 5.0:
test.support.environment_altered = True
print("Warning -- multiprocessing.Manager still has %s active " print("Warning -- multiprocessing.Manager still has %s active "
"children after %s seconds" "children after %s seconds"
% (multiprocessing.active_children(), dt), % (multiprocessing.active_children(), dt),
@ -4413,6 +4416,7 @@ class ManagerMixin(BaseMixin):
# This is not really an error since some tests do not # This is not really an error since some tests do not
# ensure that all processes which hold a reference to a # ensure that all processes which hold a reference to a
# managed object have been joined. # managed object have been joined.
test.support.environment_altered = True
print('Warning -- Shared objects which still exist at manager ' print('Warning -- Shared objects which still exist at manager '
'shutdown:') 'shutdown:')
print(cls.manager._debug_info()) print(cls.manager._debug_info())
@ -4511,6 +4515,7 @@ def install_tests_in_module_dict(remote_globs, start_method):
processes = set(multiprocessing.process._dangling) - set(dangling[0]) processes = set(multiprocessing.process._dangling) - set(dangling[0])
if processes: if processes:
need_sleep = True need_sleep = True
test.support.environment_altered = True
print('Warning -- Dangling processes: %s' % processes, print('Warning -- Dangling processes: %s' % processes,
file=sys.stderr) file=sys.stderr)
processes = None processes = None
@ -4518,6 +4523,7 @@ def install_tests_in_module_dict(remote_globs, start_method):
threads = set(threading._dangling) - set(dangling[1]) threads = set(threading._dangling) - set(dangling[1])
if threads: if threads:
need_sleep = True need_sleep = True
test.support.environment_altered = True
print('Warning -- Dangling threads: %s' % threads, print('Warning -- Dangling threads: %s' % threads,
file=sys.stderr) file=sys.stderr)
threads = None threads = None