gh-92169: Use warnings_helper.import_deprecated() to import deprecated modules uniformly in tests (GH-92170)

Lib/test/test_asynchat.py

@@ -3,6 +3,7 @@
 from test import support
 from test.support import socket_helper
 from test.support import threading_helper
+from test.support import warnings_helper
 
 import errno
 import socket
@@ -12,11 +13,9 @@ import time
 import unittest
 import unittest.mock
 
-import warnings
+
-with warnings.catch_warnings():
+asynchat = warnings_helper.import_deprecated('asynchat')
-    warnings.simplefilter('ignore', DeprecationWarning)
+asyncore = warnings_helper.import_deprecated('asyncore')
-    import asynchat
-    import asyncore
 
 support.requires_working_socket(module=True)
 

Lib/test/test_asyncore.py

@@ -20,10 +20,7 @@ if support.PGO:
 
 support.requires_working_socket(module=True)
 
-import warnings
+asyncore = warnings_helper.import_deprecated('asyncore')
-with warnings.catch_warnings():
-    warnings.simplefilter('ignore', DeprecationWarning)
-    import asyncore
 
 
 HAS_UNIX_SOCKETS = hasattr(socket, 'AF_UNIX')

Lib/test/test_ftplib.py

@@ -23,11 +23,10 @@ from test.support import socket_helper
 from test.support import warnings_helper
 from test.support.socket_helper import HOST, HOSTv6
 
-import warnings
+
-with warnings.catch_warnings():
+asynchat = warnings_helper.import_deprecated('asynchat')
-    warnings.simplefilter('ignore', DeprecationWarning)
+asyncore = warnings_helper.import_deprecated('asyncore')
-    import asyncore
+
-    import asynchat
 
 support.requires_working_socket(module=True)
 

Lib/test/test_imp.py

@@ -8,11 +8,10 @@ from test import support
 from test.support import import_helper
 from test.support import os_helper
 from test.support import script_helper
+from test.support import warnings_helper
 import unittest
 import warnings
-with warnings.catch_warnings():
+imp = warnings_helper.import_deprecated('imp')
-    warnings.simplefilter('ignore', DeprecationWarning)
-    import imp
 import _imp
 
 

Lib/test/test_logging.py

@@ -60,10 +60,10 @@ from urllib.parse import urlparse, parse_qs
 from socketserver import (ThreadingUDPServer, DatagramRequestHandler,
                           ThreadingTCPServer, StreamRequestHandler)
 
-with warnings.catch_warnings():
+
-    warnings.simplefilter('ignore', DeprecationWarning)
+asyncore = warnings_helper.import_deprecated('asyncore')
-    import asyncore
+smtpd = warnings_helper.import_deprecated('smtpd')
-    import smtpd
+
 
 try:
     import win32evtlog, win32evtlogutil, pywintypes

Lib/test/test_poplib.py

@@ -15,12 +15,12 @@ from test import support as test_support
 from test.support import hashlib_helper
 from test.support import socket_helper
 from test.support import threading_helper
+from test.support import warnings_helper
+
+
+asynchat = warnings_helper.import_deprecated('asynchat')
+asyncore = warnings_helper.import_deprecated('asyncore')
 
-import warnings
-with warnings.catch_warnings():
-    warnings.simplefilter('ignore', DeprecationWarning)
-    import asynchat
-    import asyncore
 
 test_support.requires_working_socket(module=True)
 

Lib/test/test_smtpd.py

@@ -6,11 +6,9 @@ from test.support import warnings_helper
 import socket
 import io
 
-import warnings
+
-with warnings.catch_warnings():
+smtpd = warnings_helper.import_deprecated('smtpd')
-    warnings.simplefilter('ignore', DeprecationWarning)
+asyncore = warnings_helper.import_deprecated('asyncore')
-    import smtpd
-    import asyncore
 
 
 class DummyServer(smtpd.SMTPServer):

Lib/test/test_smtplib.py

@@ -21,13 +21,13 @@ from test import support, mock_socket
 from test.support import hashlib_helper
 from test.support import socket_helper
 from test.support import threading_helper
+from test.support import warnings_helper
 from unittest.mock import Mock
 
-import warnings
+
-with warnings.catch_warnings():
+asyncore = warnings_helper.import_deprecated('asyncore')
-    warnings.simplefilter('ignore', DeprecationWarning)
+smtpd = warnings_helper.import_deprecated('smtpd')
-    import asyncore
+
-    import smtpd
 
 support.requires_working_socket(module=True)
 

Lib/test/test_ssl.py

@@ -12,7 +12,6 @@ from test.support import warnings_helper
 import socket
 import select
 import time
-import datetime
 import enum
 import gc
 import os
@@ -30,10 +29,9 @@ try:
 except ImportError:
     ctypes = None
 
-import warnings
+
-with warnings.catch_warnings():
+asyncore = warnings_helper.import_deprecated('asyncore')
-    warnings.simplefilter('ignore', DeprecationWarning)
+
-    import asyncore
 
 ssl = import_helper.import_module("ssl")
 import _ssl

Misc/NEWS.d/next/Tests/2022-05-02-20-57-04.gh-issue-92169.Xi4NGV.rst

@@ -0,0 +1,2 @@
+Use ``warnings_helper.import_deprecated()`` to import deprecated modules
+uniformly in tests. Patch by Hugo van Kemenade.