gh-109566: Remove make testall (#110122)

Remove "make testall" target: use "make buildbottest" instead.
This commit is contained in:
Victor Stinner 2023-09-29 21:36:03 +02:00 committed by GitHub
parent 6351842121
commit 9c91141fff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 19 deletions

View File

@ -1853,21 +1853,6 @@ cleantest: all
test: all test: all
$(TESTRUNNER) --fast-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS) $(TESTRUNNER) --fast-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)
# Run the full test suite twice - once without .pyc files, and once with.
# In the past, we've had problems where bugs in the marshalling or
# elsewhere caused bytecode read from .pyc files to behave differently
# than bytecode generated directly from a .py source file. Sometimes
# the bytecode read from a .pyc file had the bug, sometimes the directly
# generated bytecode. This is sometimes a very shy bug needing a lot of
# sample data.
.PHONY: testall
testall: all
-find $(srcdir)/Lib -name '*.py[co]' -exec rm -f {} ';' || true
$(TESTPYTHON) -E $(srcdir)/Lib/compileall.py
-find $(srcdir)/Lib -name '*.py[co]' -exec rm -f {} ';' || true
$(TESTRUNNER) --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)
$(TESTRUNNER) --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)
# Run the test suite for both architectures in a Universal build on OSX. # Run the test suite for both architectures in a Universal build on OSX.
# Must be run on an Intel box. # Must be run on an Intel box.
.PHONY: testuniversal .PHONY: testuniversal
@ -1880,8 +1865,9 @@ testuniversal: all
$(RUNSHARED) /usr/libexec/oah/translate \ $(RUNSHARED) /usr/libexec/oah/translate \
./$(BUILDPYTHON) -E -m test -j 0 -u all $(TESTOPTS) ./$(BUILDPYTHON) -E -m test -j 0 -u all $(TESTOPTS)
# Like testall, but with only one pass and without multiple processes. # Like test, but using --slow-ci which enables all test resources and use
# Run an optional script to include information about the build environment. # longer timeout. Run an optional pybuildbot.identify script to include
# information about the build environment.
.PHONY: buildbottest .PHONY: buildbottest
buildbottest: all buildbottest: all
-@if which pybuildbot.identify >/dev/null 2>&1; then \ -@if which pybuildbot.identify >/dev/null 2>&1; then \
@ -1889,7 +1875,7 @@ buildbottest: all
fi fi
$(TESTRUNNER) --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS) $(TESTRUNNER) --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)
# Like testall, but run Python tests with HOSTRUNNER directly. # Like buildbottest, but run Python tests with HOSTRUNNER directly.
.PHONY: hostrunnertest .PHONY: hostrunnertest
hostrunnertest: all hostrunnertest: all
$(RUNSHARED) $(HOSTRUNNER) ./$(BUILDPYTHON) -m test --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS) $(RUNSHARED) $(HOSTRUNNER) ./$(BUILDPYTHON) -m test --slow-ci --timeout=$(TESTTIMEOUT) $(TESTOPTS)

View File

@ -0,0 +1,2 @@
Remove ``make testall`` target: use ``make buildbottest`` instead. Patch by
Victor Stinner.

View File

@ -177,7 +177,7 @@ is printed about a failed test or a traceback or core dump is produced,
something is wrong. something is wrong.
By default, tests are prevented from overusing resources like disk space and By default, tests are prevented from overusing resources like disk space and
memory. To enable these tests, run ``make testall``. memory. To enable these tests, run ``make buildbottest``.
If any tests fail, you can re-run the failing test(s) in verbose mode. For If any tests fail, you can re-run the failing test(s) in verbose mode. For
example, if ``test_os`` and ``test_gdb`` failed, you can run:: example, if ``test_os`` and ``test_gdb`` failed, you can run::