1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gh-100220: Fix error handling in make rules (GH-100328)

Browse Source 
Set `SHELL = /bin/sh -e` to ensure that complex recipes fail on the first error rather than incorrectly reporting success.

Co-authored-by: Zachary Ware <zach@python.org>
This commit is contained in:
Michał Górny 2023-04-07 18:23:59 +00:00 committed by GitHub
parent 2667452945
commit a90863c993
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile.pre.in
View File

@ -59,7 +59,7 @@ DSYMUTIL_PATH= @DSYMUTIL_PATH@
GNULD= @GNULD@
# Shell used by make (some versions default to the login shell, which is bad)
SHELL= /bin/sh
SHELL= /bin/sh -e
# Use this to make a link between python$(VERSION) and python in $(BINDIR)
LN= @LN@

4
Misc/NEWS.d/next/Build/2022-12-18-07-24-44.gh-issue-100220.BgSV7C.rst Normal file
View File

@ -0,0 +1,4 @@
Changed the default value of the ``SHELL`` Makefile variable from ``/bin/sh``
to ``/bin/sh -e`` to ensure that complex recipes correctly fail after an error.
Previously, ``make install`` could fail to install some files and yet return
a successful result.