1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-43102: Set namedtuple __new__'s internal builtins to a dict. (GH-24439)

Browse Source
This commit is contained in:
Raymond Hettinger 2021-02-04 15:52:16 -08:00 committed by GitHub
parent 196d4deaf4
commit b6d68aa08b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Lib/collections/__init__.py
View File

@ -407,7 +407,7 @@ def namedtuple(typename, field_names, *, rename=False, defaults=None, module=Non
namespace = { namespace = {
'_tuple_new': tuple_new, '_tuple_new': tuple_new,
'__builtins__': None, '__builtins__': {},
'__name__': f'namedtuple_{typename}', '__name__': f'namedtuple_{typename}',
} }
code = f'lambda _cls, {arg_list}: _tuple_new(_cls, ({arg_list}))' code = f'lambda _cls, {arg_list}: _tuple_new(_cls, ({arg_list}))'

5
Lib/test/test_collections.py
View File

@ -681,6 +681,11 @@ class TestNamedTuple(unittest.TestCase):
self.assertEqual(np.x, 1) self.assertEqual(np.x, 1)
self.assertEqual(np.y, 2) self.assertEqual(np.y, 2)
def test_new_builtins_issue_43102(self):
self.assertEqual(
namedtuple('C', ()).__new__.__globals__['__builtins__'],
{})
################################################################################ ################################################################################
### Abstract Base Classes ### Abstract Base Classes

2
Misc/NEWS.d/next/Library/2021-02-03-22-55-27.bpo-43102.TSlZ6J.rst Normal file
View File

@ -0,0 +1,2 @@
The namedtuple __new__ method had its __builtins__ set to None instead
of an actual dictionary. This created problems for introspection tools.