1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix probable bug; if errno == EINTR, floatsleep() doesn't break out of

Browse Source 
a Py_BEGIN_ALLOW_THREADS/Py_END_ALLOW_THREADS block, but it
   calls Py_BLOCK_THREADS anyway. The change moves Py_BLOCK_THREADS
   to inside the if, so it's only executed when the function
   actually returns unexpectedly.
This commit is contained in:
Andrew M. Kuchling 2000-03-24 20:35:20 +00:00
parent 70b5d47f71
commit c24ca4b192
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Modules/timemodule.c
View File

@ -755,12 +755,12 @@ floatsleep(double secs)
t.tv_usec = (long)(frac*1000000.0); t.tv_usec = (long)(frac*1000000.0);
Py_BEGIN_ALLOW_THREADS Py_BEGIN_ALLOW_THREADS
if (select(0, (fd_set *)0, (fd_set *)0, (fd_set *)0, &t) != 0) { if (select(0, (fd_set *)0, (fd_set *)0, (fd_set *)0, &t) != 0) {
Py_BLOCK_THREADS
#ifdef EINTR #ifdef EINTR
if (errno != EINTR) { if (errno != EINTR) {
#else #else
if (1) { if (1) {
#endif #endif
Py_BLOCK_THREADS
PyErr_SetFromErrno(PyExc_IOError); PyErr_SetFromErrno(PyExc_IOError);
return -1; return -1;
} }