1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

long_pow(): Fix more instances of leaks in error cases.

Browse Source 
Bugfix candidate -- although long_pow() is so different now I doubt a
patch would apply to 2.3.
This commit is contained in:
Tim Peters 2004-08-30 02:58:59 +00:00
parent 47e52ee0c5
commit cd97da3b1d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Objects/longobject.c
View File

@ -2343,7 +2343,7 @@ long_pow(PyObject *v, PyObject *w, PyObject *x)
if (c) { if (c) {
PyErr_SetString(PyExc_TypeError, "pow() 2nd argument " PyErr_SetString(PyExc_TypeError, "pow() 2nd argument "
"cannot be negative when 3rd argument specified"); "cannot be negative when 3rd argument specified");
return NULL; goto Error;
} }
else { else {
/* else return a float. This works because we know /* else return a float. This works because we know
@ -2361,7 +2361,7 @@ long_pow(PyObject *v, PyObject *w, PyObject *x)
if (c->ob_size == 0) { if (c->ob_size == 0) {
PyErr_SetString(PyExc_ValueError, PyErr_SetString(PyExc_ValueError,
"pow() 3rd argument cannot be 0"); "pow() 3rd argument cannot be 0");
goto Done; goto Error;
} }
/* if modulus < 0: /* if modulus < 0:
@ -2390,7 +2390,7 @@ long_pow(PyObject *v, PyObject *w, PyObject *x)
Having the base positive just makes things easier. */ Having the base positive just makes things easier. */
if (a->ob_size < 0) { if (a->ob_size < 0) {
if (l_divmod(a, c, NULL, &temp) < 0) if (l_divmod(a, c, NULL, &temp) < 0)
goto Done; goto Error;
Py_DECREF(a); Py_DECREF(a);
a = temp; a = temp;
temp = NULL; temp = NULL;