1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bpo-34303: Micro-optimizations in functools.reduce() (GH-8598)

Browse Source
This commit is contained in:
Sergey Fedoseev 2019-06-02 01:32:18 +05:00 committed by Raymond Hettinger
parent 3b57f50efc
commit e5f6207ba6
2 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Misc/NEWS.d/next/Library/2018-08-03-09-47-20.bpo-34303.tOE2HP.rst Normal file
View File

@ -0,0 +1,2 @@
Performance of :func:`functools.reduce` is slightly improved. Patch by
Sergey Fedoseev.

9
Modules/_functoolsmodule.c
View File

@ -626,10 +626,13 @@ functools_reduce(PyObject *self, PyObject *args)
if (result == NULL) if (result == NULL)
result = op2; result = op2;
else { else {
PyTuple_SetItem(args, 0, result); /* Update the args tuple in-place */
PyTuple_SetItem(args, 1, op2); assert(args->ob_refcnt == 1);
if ((result = PyEval_CallObject(func, args)) == NULL) Py_XSETREF(_PyTuple_ITEMS(args)[0], result);
Py_XSETREF(_PyTuple_ITEMS(args)[1], op2);
if ((result = PyObject_Call(func, args, NULL)) == NULL) {
goto Fail; goto Fail;
}
} }
} }