1berry/cpython
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

gh-134262: Fix off by one errors in download retry functions (GH-134867)

Browse Source
This commit is contained in:
Emma Smith 2025-05-28 16:15:39 -07:00 committed by GitHub
parent e9d845b41d
commit e64395e8eb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PCbuild/get_external.py
View File

@ -12,7 +12,7 @@ from urllib.request import urlretrieve
def retrieve_with_retries(download_location, output_path, reporthook,
max_retries=7):
"""Download a file with exponential backoff retry and save to disk."""
for attempt in range(max_retries):
for attempt in range(max_retries + 1):
try:
resp = urlretrieve(
download_location,

2
Tools/build/generate_sbom.py
View File

@ -169,7 +169,7 @@ def download_with_retries(download_location: str,
base_delay: float = 2.25,
max_jitter: float = 1.0) -> typing.Any:
"""Download a file with exponential backoff retry."""
for attempt in range(max_retries):
for attempt in range(max_retries + 1):
try:
resp = urllib.request.urlopen(download_location)
except urllib.error.URLError as ex: