docker-cli/dockerfiles/Dockerfile.lint

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.24.4
ARG ALPINE_VERSION=3.21
ARG GOLANGCI_LINT_VERSION=v2.1.5

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint
ENV GOTOOLCHAIN=local
ENV GO111MODULE=off
ENV CGO_ENABLED=0
ENV GOGC=75
WORKDIR /go/src/github.com/docker/cli
COPY --link --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
        golangci-lint run
Dockerfile: use syntax=docker/dockerfile:1 Now that HEREDOC is included in the stable Dockerfile syntax, we can use the latest stable syntax for all Dockerfiles. The recommendation for the stable syntax is to use `:1` (which is equivalent to "latest" stable syntax. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-03-17 10:37:08 +01:00			`# syntax=docker/dockerfile:1`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
update to go1.24.4 - https://github.com/golang/go/issues?q=milestone%3AGo1.24.4+label%3ACherryPickApproved - full diff: https://github.com/golang/go/compare/go1.24.3...go1.24.4 This release includes 3 security fixes following the security policy: - net/http: sensitive headers not cleared on cross-origin redirect Proxy-Authorization and Proxy-Authenticate headers persisted on cross-origin redirects potentially leaking sensitive information. Thanks to Takeshi Kaneko (GMO Cybersecurity by Ierae, Inc.) for reporting this issue. This is CVE-2025-4673 and Go issue https://go.dev/issue/73816. - os: inconsistent handling of O_CREATE\|O_EXCL on Unix and Windows os.OpenFile(path, os.O_CREATE\|O_EXCL) behaved differently on Unix and Windows systems when the target path was a dangling symlink. On Unix systems, OpenFile with O_CREATE and O_EXCL flags never follows symlinks. On Windows, when the target path was a symlink to a nonexistent location, OpenFile would create a file in that location. OpenFile now always returns an error when the O_CREATE and O_EXCL flags are both set and the target path is a symlink. Thanks to Junyoung Park and Dong-uk Kim of KAIST Hacking Lab for discovering this issue. This is CVE-2025-0913 and Go issue https://go.dev/issue/73702. - crypto/x509: usage of ExtKeyUsageAny disables policy validation Calling Verify with a VerifyOptions.KeyUsages that contains ExtKeyUsageAny unintentionally disabledpolicy validation. This only affected certificate chains which contain policy graphs, which are rather uncommon. Thanks to Krzysztof Skrzętnicki (@Tener) of Teleport for reporting this issue. This is CVE-2025-22874 and Go issue https://go.dev/issue/73612. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> 2025-06-09 16:22:11 +02:00			`ARG GO_VERSION=1.24.4`
Dockerfile: update to alpine 3.21 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2025-01-21 18:17:45 +01:00			`ARG ALPINE_VERSION=3.21`
Dockerfile: update golangci-lint to v2.1.5 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2025-05-19 20:16:23 +02:00			`ARG GOLANGCI_LINT_VERSION=v2.1.5`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 08:44:16 +02:00			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`
Add gometalinter to CI Signed-off-by: Daniel Nephin <dnephin@docker.com> 2017-05-02 15:10:03 -04:00
Dockerfile: add ALPINE_VERSION build-arg This allows us to pin to a specific version of Alpine, in case the golang:alpine image switches to a newer version, which may at times be incompatible, e.g. see https://github.com/moby/moby/issues/44570 Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-12-04 14:01:30 +01:00			`FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS lint`
Dockerfile: use GOTOOLCHAIN=local This may find its way into the official images, but until it does, let's make sure we don't get unexpected updates of go. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-09-26 12:43:38 +02:00			`ENV GOTOOLCHAIN=local`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 08:44:16 +02:00			`ENV GO111MODULE=off`
			`ENV CGO_ENABLED=0`
			`ENV GOGC=75`
Remove now obsolete gometalinter and use golangci-lint instead Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2019-04-02 17:27:12 +02:00			`WORKDIR /go/src/github.com/docker/cli`
Dockerfile: use COPY --link where possible Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-08-25 01:56:35 +02:00			`COPY --link --from=golangci-lint /usr/bin/golangci-lint /usr/bin/golangci-lint`
GitHub Actions for lint Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2021-08-05 08:44:16 +02:00			`RUN --mount=type=bind,target=. \`
			`--mount=type=cache,target=/root/.cache \`
			`golangci-lint run`