diff --git a/pkg/compose/build.go b/pkg/compose/build.go index 150911831..027a3dd01 100644 --- a/pkg/compose/build.go +++ b/pkg/compose/build.go @@ -27,7 +27,7 @@ import ( _ "github.com/docker/buildx/driver/docker" // required to get default driver registered "github.com/docker/buildx/util/buildflags" xprogress "github.com/docker/buildx/util/progress" - "github.com/docker/docker/pkg/urlutil" + "github.com/docker/docker/builder/remotecontext/urlutil" bclient "github.com/moby/buildkit/client" "github.com/moby/buildkit/session" "github.com/moby/buildkit/session/auth/authprovider" diff --git a/pkg/compose/build_classic.go b/pkg/compose/build_classic.go index 6d2d65c3d..c019eb01b 100644 --- a/pkg/compose/build_classic.go +++ b/pkg/compose/build_classic.go @@ -30,13 +30,13 @@ import ( buildx "github.com/docker/buildx/build" "github.com/docker/cli/cli/command/image/build" dockertypes "github.com/docker/docker/api/types" + "github.com/docker/docker/builder/remotecontext/urlutil" "github.com/docker/docker/cli" "github.com/docker/docker/pkg/archive" "github.com/docker/docker/pkg/idtools" "github.com/docker/docker/pkg/jsonmessage" "github.com/docker/docker/pkg/progress" "github.com/docker/docker/pkg/streamformatter" - "github.com/docker/docker/pkg/urlutil" "github.com/hashicorp/go-multierror" "github.com/pkg/errors" diff --git a/pkg/compose/create.go b/pkg/compose/create.go index a0b74a0e5..9a57915ee 100644 --- a/pkg/compose/create.go +++ b/pkg/compose/create.go @@ -1155,7 +1155,7 @@ func (s *composeService) createVolume(ctx context.Context, volume types.VolumeCo eventName := fmt.Sprintf("Volume %q", volume.Name) w := progress.ContextWriter(ctx) w.Event(progress.CreatingEvent(eventName)) - _, err := s.apiClient().VolumeCreate(ctx, volume_api.VolumeCreateBody{ + _, err := s.apiClient().VolumeCreate(ctx, volume_api.CreateOptions{ Labels: volume.Labels, Name: volume.Name, Driver: volume.Driver, diff --git a/pkg/compose/down.go b/pkg/compose/down.go index 7d7549660..57e46e87a 100644 --- a/pkg/compose/down.go +++ b/pkg/compose/down.go @@ -19,10 +19,11 @@ package compose import ( "context" "fmt" - "github.com/docker/compose/v2/pkg/utils" "strings" "time" + "github.com/docker/compose/v2/pkg/utils" + "github.com/compose-spec/compose-go/types" moby "github.com/docker/docker/api/types" containerType "github.com/docker/docker/api/types/container" diff --git a/pkg/compose/down_test.go b/pkg/compose/down_test.go index 508954de8..a03fee3ab 100644 --- a/pkg/compose/down_test.go +++ b/pkg/compose/down_test.go @@ -54,7 +54,7 @@ func TestDown(t *testing.T) { testContainer("service_orphan", "321", true), }, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{}, nil) + Return(volume.ListResponse{}, nil) // network names are not guaranteed to be unique, ensure Compose handles // cleanup properly if duplicates are inadvertently created @@ -104,7 +104,7 @@ func TestDownRemoveOrphans(t *testing.T) { testContainer("service_orphan", "321", true), }, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{}, nil) + Return(volume.ListResponse{}, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return([]moby.NetworkResource{{Name: "myProject_default"}}, nil) @@ -140,8 +140,8 @@ func TestDownRemoveVolumes(t *testing.T) { api.EXPECT().ContainerList(gomock.Any(), projectFilterListOpt(false)).Return( []moby.Container{testContainer("service1", "123", false)}, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{ - Volumes: []*moby.Volume{{Name: "myProject_volume"}}, + Return(volume.ListResponse{ + Volumes: []*volume.Volume{{Name: "myProject_volume"}}, }, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return(nil, nil) @@ -277,8 +277,8 @@ func TestDownRemoveImages_NoLabel(t *testing.T) { []moby.Container{container}, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{ - Volumes: []*moby.Volume{{Name: "myProject_volume"}}, + Return(volume.ListResponse{ + Volumes: []*volume.Volume{{Name: "myProject_volume"}}, }, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return(nil, nil) diff --git a/pkg/compose/kill_test.go b/pkg/compose/kill_test.go index b91a34a23..a9f623eea 100644 --- a/pkg/compose/kill_test.go +++ b/pkg/compose/kill_test.go @@ -54,7 +54,7 @@ func TestKillAll(t *testing.T) { }).Return( []moby.Container{testContainer("service1", "123", false), testContainer("service1", "456", false), testContainer("service2", "789", false)}, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{}, nil) + Return(volume.ListResponse{}, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return([]moby.NetworkResource{ {ID: "abc123", Name: "testProject_default"}, @@ -87,7 +87,7 @@ func TestKillSignal(t *testing.T) { ctx := context.Background() api.EXPECT().ContainerList(ctx, listOptions).Return([]moby.Container{testContainer(serviceName, "123", false)}, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{}, nil) + Return(volume.ListResponse{}, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return([]moby.NetworkResource{ {ID: "abc123", Name: "testProject_default"}, diff --git a/pkg/compose/ps_test.go b/pkg/compose/ps_test.go index a7e1ac9bf..6372a8ae1 100644 --- a/pkg/compose/ps_test.go +++ b/pkg/compose/ps_test.go @@ -51,7 +51,7 @@ func TestPs(t *testing.T) { c2, inspect2 := containerDetails("service1", "456", "running", "", 0) c2.Ports = []moby.Port{{PublicPort: 80, PrivatePort: 90, IP: "localhost"}} c3, inspect3 := containerDetails("service2", "789", "exited", "", 130) - api.EXPECT().VolumeList(ctx, gomock.Any()).Return(volume.VolumeListOKBody{}, nil) + api.EXPECT().VolumeList(ctx, gomock.Any()).Return(volume.ListResponse{}, nil) api.EXPECT().NetworkList(ctx, gomock.Any()).Return([]moby.NetworkResource{}, nil) api.EXPECT().ContainerList(ctx, listOpts).Return([]moby.Container{c1, c2, c3}, nil) api.EXPECT().ContainerInspect(anyCancellableContext(), "123").Return(inspect1, nil) diff --git a/pkg/compose/stop_test.go b/pkg/compose/stop_test.go index 5e3371b31..01449b40f 100644 --- a/pkg/compose/stop_test.go +++ b/pkg/compose/stop_test.go @@ -18,11 +18,12 @@ package compose import ( "context" - "github.com/docker/compose/v2/pkg/utils" "strings" "testing" "time" + "github.com/docker/compose/v2/pkg/utils" + compose "github.com/docker/compose/v2/pkg/api" "github.com/docker/compose/v2/pkg/mocks" containerType "github.com/docker/docker/api/types/container" @@ -53,7 +54,7 @@ func TestStopTimeout(t *testing.T) { testContainer("service2", "789", false), }, nil) api.EXPECT().VolumeList(gomock.Any(), filters.NewArgs(projectFilter(strings.ToLower(testProject)))). - Return(volume.VolumeListOKBody{}, nil) + Return(volume.ListResponse{}, nil) api.EXPECT().NetworkList(gomock.Any(), moby.NetworkListOptions{Filters: filters.NewArgs(projectFilter(strings.ToLower(testProject)))}). Return([]moby.NetworkResource{}, nil)