Andrii Telesh
3ca75bdf55
Fix the inability to restart the Compose stack after network configuration change
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-06-02 18:57:07 +02:00
Sebastiaan van Stijn
ad4cbee498
bump github.com/docker/docker, docker/cli v28.2.2
...
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-06-02 10:39:56 +02:00
Nicolas De Loof
23fef850b9
prefer use of slices.DeleteFunc
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-05-27 15:16:50 +02:00
Nicolas De Loof
6e35652182
fix support for remote absolute path
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-28 11:05:06 +02:00
Nicolas De Loof
955e4ed94e
introduce networks.interface_name
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-24 12:06:17 +02:00
Guillaume Lours
f5491328bb
remove support of Synchronize File Shares integration with Docker Desktop
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2025-04-22 15:29:23 +02:00
Nicolas De Loof
a3f88a0a1d
test to cover preference for bind API
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-11 09:53:48 +02:00
Nicolas De Loof
c83f1285a8
use bind API for bind mounts
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-10 18:58:20 +02:00
Nicolas De Loof
0c37c10964
mount API is not strictly equivalent to bind
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-10 11:52:35 +02:00
Nicolas De Loof
01e83defc2
introduce volume.type=image
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-04-09 16:59:42 +02:00
Guillaume Lours
7bedb5a02c
bump golangci-lint to version v2.0.2
...
and apply migration script
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2025-03-31 18:50:15 +02:00
Nicolas De Loof
da2eff4ba7
add support for gw_priority, enable_ipv4 (requires docker v28.0)
...
This adds support for the GwPriority API field in API v1.48 (docker v28.0).
It can be set on both docker container run and docker network connect.
This option is used by the Engine to determine which network provides
the default gateway for a container.
It also adds support for enable_ipv4, which allows enabling (default)
or disabling IPv4 address assignment for a network.
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-02-21 15:54:41 +01:00
Sebastiaan van Stijn
cf2fc2005c
go.mod: docker/docker, docker/cli v28.0.0, buildx v0.21.1
...
full diff:
- https://github.com/docker/docker/compare/v27.5.1...v28.0.0
- https://github.com/docker/cli/compare/v27.5.1...v28.0.0
- https://github.com/docker/buildx/compare/v0.20.1...v0.21.1
Co-authored-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2025-02-21 15:23:25 +01:00
Rafael Buchbinder
52578c0998
Properly handle "builtin" seccomp profile
...
Like in CLI [1] the "builtin" seccomp profile should be handled the same
as "unconfined".
[1] f4a68da195/cli/command/container/opts.go (L929)
Signed-off-by: Rafael Buchbinder <rafi@rbk.io>
2025-01-20 15:06:09 +01:00
Nicolas De Loof
e81de103db
simplification
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2025-01-10 12:21:13 +01:00
Florian Apolloner
2ebb475433
Only override service mac if set on the main network.
...
Signed-off-by: Florian Apolloner <florian@apolloner.eu>
2025-01-07 16:16:33 +01:00
Guillaume Tardif
571a1af013
When retrying to resolveOrCreateNetwork, retry with a valid network name
...
Signed-off-by: Guillaume Tardif <guillaume.tardif@gmail.com>
2025-01-06 08:28:05 +01:00
Sebastiaan van Stijn
446e00520c
format code with gofumpt
...
Format the code with gofumpt to prevent my IDE from reformatting
every time I open a file. gofumpt provides a superset of gofmt,
so should not impact users that are not using gofumpt.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-12-17 16:50:14 +01:00
Nicolas De Loof
8e0520e71e
prompt user to confirm volume recreation
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-12-12 19:11:00 +01:00
Joana Hrotko
332311358e
Recreate container on volume configuration change
...
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-12-12 19:11:00 +01:00
Nicolas De Loof
fc566509d5
fix support for service.mac_address
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-12-10 15:59:26 +01:00
Nicolas De Loof
c21d4cfb40
detect network config changes and recreate if needed
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-11-15 15:35:49 +01:00
Nicolas De Loof
aa1ec4524c
connect to external networks by name
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-25 16:42:28 +02:00
Nicolas De Loof
a4ee6ca7a5
don't warn about uid/gid not being supported while ... they are
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-25 12:48:00 +02:00
Nicolas De Loof
fa24ab8e25
one-off container are not indexed, and must be ignored by exec --index command
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-22 15:29:12 +02:00
Nicolas De Loof
813900180e
compose-go clean volume target to avoid ambiguous comparisons
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-22 11:40:35 +02:00
Nicolas De Loof
82417bd5bc
add support for bind.recursive
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-16 22:19:58 +02:00
divinity76
0cbb73c024
Improve error message to include expected network label
...
Updated the error message when a network is found with an incorrect label to also display the expected label value. This provides more context for debugging.
Signed-off-by: divinity76 <hans@loltek.net>
2024-10-15 15:33:16 +02:00
Nicolas De Loof
9eeb2d3154
convert gpus to DeviceRequests with implicit "gpu" capability
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-09 15:18:49 +02:00
Nicolas De Loof
3a95a0872d
add support for CDI device request using devices
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-08 11:27:22 +02:00
Nicolas De Loof
82b41b9ebd
introduce service hooks
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-07 16:06:41 +02:00
Nicolas De Loof
6c06170eb0
pass device.options to engine
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-10-04 14:55:53 +02:00
Joana Hrotko
41df35c1f4
Remove bind options when creating a volume type
...
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
2024-10-02 10:00:28 +02:00
Nicolas De Loof
34b18194f7
check secret source exists, as bind mount would create target as a folder otherwise
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-09-23 19:36:41 +02:00
Guillaume Lours
9c60fe67df
revert commits link to mount API over bind changes
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2024-09-20 10:37:57 +02:00
Nicolas De Loof
c16df17e1f
don't set propagation if target engine isn't linux
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-09-18 17:54:19 +02:00
Nicolas De Loof
cb00aaad28
set propagation default
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-09-17 10:50:16 +02:00
Guillaume Lours
8db0cba0af
bump compose-go to version v2.2.0
...
Signed-off-by: Guillaume Lours <705411+glours@users.noreply.github.com>
2024-09-12 09:36:18 +02:00
Nathan Baulch
524a97e553
Fix typos
...
Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>
2024-09-11 11:21:24 +02:00
Nicolas De Loof
f9c7a0cc08
prefer mount API over bind
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-08-26 16:05:04 +01:00
Nicolas De Loof
d3d378b92a
restore setEnvWithDotEnv
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-07-11 10:25:04 +02:00
Nicolas De Loof
25f85938bb
exclude unnecessary resources after services have been selected
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-07-09 15:12:27 +02:00
Albin Kerouanton
6a000dcff1
go.mod: github.com/compose-spec/compose-go v2.1.3
...
full diff:
- https://github.com/compose-spec/compose-go/compare/v2.1.2...v2.1.3
Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-06-21 14:04:40 +02:00
Albin Kerouanton
2636dcf064
go.mod: docker/docker and docker/cli v27.0.1-rc.1
...
diffs:
- https://github.com/docker/cli/compare/v26.1.4..v27.0.1-rc.1
- https://github.com/docker/docker/compare/v26.1.4..v27.0.1-rc.1
Co-authored-by: Albin Kerouanton <albinker@gmail.com
Signed-off-by: Albin Kerouanton <albinker@gmail.com
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2024-06-21 14:04:40 +02:00
Rob Murray
048fd136d2
Set endpoint-specific DriverOpts
...
Signed-off-by: Rob Murray <rob.murray@docker.com>
2024-05-22 12:39:20 +02:00
Milas Bowman
922422a539
fix: do not try to create file shares for non-directories
...
When creating automatic file shares, ignore any non-directory
bind mounts, e.g. for an individual (normal) file or a special
type like a Unix socket (`/var/run/docker.sock`).
Additionally, there's no need to create a directory if one
does not exist, the API will handle that. However, the check
for existence remains so that `create_host_path: false`
mounts can be ignored.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2024-04-17 17:12:03 +02:00
Nicolas De Loof
d239f0f318
check container_name is not in use by another service we will create
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-16 17:26:50 +02:00
Nicolas De Loof
b3792dd258
progress for resource can be restarted after more Working event comes
...
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
2024-04-15 22:05:46 +02:00
Milas Bowman
3371227794
chore(desktop): revised feature detection for file shares
...
Unfortunately, the feature flag mechanism for experimental features
isn't adequate. To avoid some edge cases where Compose might try to
use Synchronized file shares with Desktop when the feature isn't
available, we need to query a new endpoint.
Before we move any of this out of experimental, we need to improve
the integration here with Desktop & Compose so that we get all the
necessary feature/experiment state up-front to reduce the quantity
of IPC calls needed up-front.
For now, there's some intentional redundancy to avoid making this
extra call if we can avoid it. The actual endpoint is very cheap/
fast, but every IPC call is a potential point of of failure, so
it's worth it.
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
2024-03-22 18:16:27 +01:00
Joana Hrotko
e9dc82011f
Add Navigation Menu to compose up
...
Signed-off-by: Joana Hrotko <joana.hrotko@docker.com>
2024-03-22 17:48:25 +01:00