AbstractBaseTest class for sharing setUp and tearDown in tests

tests/test_common.py

@@ -46,8 +46,8 @@ def _mock_common_module_options_instance():
     fdroidserver.common.options.verbose = False
 
 
-class CommonTest(unittest.TestCase):
-    '''fdroidserver/common.py'''
+class SetUpTearDownMixin:
+    """A mixin with no tests in it for shared setUp and tearDown."""
 
     def setUp(self):
         logging.basicConfig(level=logging.DEBUG)
@@ -77,6 +77,10 @@ class CommonTest(unittest.TestCase):
         if os.path.exists(self.tmpdir):
             shutil.rmtree(self.tmpdir)
 
+
+class CommonTest(SetUpTearDownMixin, unittest.TestCase):
+    '''fdroidserver/common.py'''
+
     def test_yaml_1_2(self):
         """Return a ruamel.yaml instance that supports YAML 1.2
 
@@ -3307,7 +3311,7 @@ class SignerExtractionTest(unittest.TestCase):
             )
 
 
-class IgnoreApksignerV33Test(CommonTest):
+class IgnoreApksignerV33Test(SetUpTearDownMixin, unittest.TestCase):
     """apksigner v33 should be entirely ignored
 
     https://gitlab.com/fdroid/fdroidserver/-/issues/1253

tests/test_lint.py

@@ -19,8 +19,8 @@ from fdroidserver._yaml import config_dump
 basedir = Path(__file__).parent
 
 
-class LintTest(unittest.TestCase):
-    '''fdroidserver/lint.py'''
+class SetUpTearDownMixin:
+    """A base class with no test in it for shared setUp and tearDown."""
 
     def setUp(self):
         os.chdir(basedir)
@@ -33,6 +33,10 @@ class LintTest(unittest.TestCase):
     def tearDown(self):
         self._td.cleanup()
 
+
+class LintTest(SetUpTearDownMixin, unittest.TestCase):
+    '''fdroidserver/lint.py'''
+
     def test_check_for_unsupported_metadata_files(self):
         self.assertTrue(fdroidserver.lint.check_for_unsupported_metadata_files())