CLEANUP: sink: remove useless cleanup in sink_new_from_logger()

As reported by Ilya in GH #2994, some cleanup parts in
sink_new_from_logger() function are not used.

We can actually simplify the cleanup logic to remove dead code, let's
do that by renaming "error_final" label to "error" and only making use
of the "error" label, because sink_free() already takes care of proper
cleanup for all sink members.
This commit is contained in:
Aurelien DARRAGON 2025-06-04 16:51:04 +02:00
parent 8c4bb8cab3
commit 89b04f2191

View File

@ -1268,15 +1268,11 @@ struct sink *sink_new_from_logger(struct logger *logger)
HA_SPIN_INIT(&srv->lock);
if (sink_finalize(sink) & ERR_CODE)
goto error_final;
goto error;
return sink;
error:
if (srv)
srv_detach(srv);
srv_drop(srv);
error_final:
error:
sink_free(sink);
return NULL;