2017-01-06 19:11:07 -05:00
|
|
|
/**
|
|
|
|
* @fileoverview Prohibit the `if (err) throw err;` pattern
|
|
|
|
* @author Teddy Katz
|
|
|
|
*/
|
|
|
|
|
|
|
|
'use strict';
|
|
|
|
|
2017-11-01 01:31:02 +05:30
|
|
|
const utils = require('./rules-utils.js');
|
|
|
|
|
2017-01-06 19:11:07 -05:00
|
|
|
module.exports = {
|
2020-08-01 14:22:51 -04:00
|
|
|
meta: {
|
2022-12-18 17:39:39 +01:00
|
|
|
fixable: 'code',
|
2020-08-01 14:22:51 -04:00
|
|
|
},
|
2017-01-06 19:11:07 -05:00
|
|
|
create(context) {
|
2024-05-09 17:27:39 +02:00
|
|
|
const sourceCode = context.sourceCode;
|
2019-03-02 23:07:03 +09:00
|
|
|
let assertImported = false;
|
2017-01-06 19:11:07 -05:00
|
|
|
|
|
|
|
function hasSameTokens(nodeA, nodeB) {
|
|
|
|
const aTokens = sourceCode.getTokens(nodeA);
|
|
|
|
const bTokens = sourceCode.getTokens(nodeB);
|
|
|
|
|
|
|
|
return aTokens.length === bTokens.length &&
|
|
|
|
aTokens.every((token, index) => {
|
|
|
|
return token.type === bTokens[index].type &&
|
|
|
|
token.value === bTokens[index].value;
|
|
|
|
});
|
|
|
|
}
|
|
|
|
|
2017-11-01 01:31:02 +05:30
|
|
|
function checkAssertNode(node) {
|
|
|
|
if (utils.isRequired(node, ['assert'])) {
|
|
|
|
assertImported = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-01-06 19:11:07 -05:00
|
|
|
return {
|
2017-11-01 01:31:02 +05:30
|
|
|
'CallExpression': (node) => checkAssertNode(node),
|
|
|
|
'IfStatement': (node) => {
|
2017-01-06 19:11:07 -05:00
|
|
|
const firstStatement = node.consequent.type === 'BlockStatement' ?
|
|
|
|
node.consequent.body[0] :
|
|
|
|
node.consequent;
|
|
|
|
if (
|
|
|
|
firstStatement &&
|
|
|
|
firstStatement.type === 'ThrowStatement' &&
|
|
|
|
hasSameTokens(node.test, firstStatement.argument)
|
|
|
|
) {
|
2017-11-01 01:31:02 +05:30
|
|
|
const argument = sourceCode.getText(node.test);
|
2017-01-06 19:11:07 -05:00
|
|
|
context.report({
|
|
|
|
node: firstStatement,
|
|
|
|
message: 'Use assert.ifError({{argument}}) instead.',
|
2017-11-01 01:31:02 +05:30
|
|
|
data: { argument },
|
|
|
|
fix: (fixer) => {
|
|
|
|
if (assertImported) {
|
|
|
|
return fixer.replaceText(
|
|
|
|
node,
|
2022-12-18 17:39:39 +01:00
|
|
|
`assert.ifError(${argument});`,
|
2017-11-01 01:31:02 +05:30
|
|
|
);
|
|
|
|
}
|
2022-12-18 17:39:39 +01:00
|
|
|
},
|
2017-01-06 19:11:07 -05:00
|
|
|
});
|
|
|
|
}
|
2022-12-18 17:39:39 +01:00
|
|
|
},
|
2017-01-06 19:11:07 -05:00
|
|
|
};
|
2022-12-18 17:39:39 +01:00
|
|
|
},
|
2017-01-06 19:11:07 -05:00
|
|
|
};
|