2020-09-06 22:27:07 +02:00
|
|
|
'use strict';
|
|
|
|
|
|
|
|
const common = require('../common');
|
2021-12-07 02:01:36 -08:00
|
|
|
if ((!common.hasCrypto) || (!common.hasIntl)) {
|
|
|
|
common.skip('ESLint tests require crypto and Intl');
|
|
|
|
}
|
2020-09-06 22:27:07 +02:00
|
|
|
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
|
2024-06-19 21:54:08 +02:00
|
|
|
const RuleTester = require('../../tools/eslint/node_modules/eslint').RuleTester;
|
2020-09-06 22:27:07 +02:00
|
|
|
const rule = require('../../tools/eslint-rules/prefer-common-mustsucceed');
|
|
|
|
|
|
|
|
const msg1 = 'Please use common.mustSucceed instead of ' +
|
|
|
|
'common.mustCall(assert.ifError).';
|
|
|
|
const msg2 = 'Please use common.mustSucceed instead of ' +
|
|
|
|
'common.mustCall with assert.ifError.';
|
|
|
|
|
2024-05-23 21:45:18 +02:00
|
|
|
new RuleTester().run('prefer-common-mustsucceed', rule, {
|
2020-09-06 22:27:07 +02:00
|
|
|
valid: [
|
|
|
|
'foo((err) => assert.ifError(err))',
|
|
|
|
'foo(function(err) { assert.ifError(err) })',
|
|
|
|
'foo(assert.ifError)',
|
2021-03-26 08:51:08 -07:00
|
|
|
'common.mustCall((err) => err)',
|
2020-09-06 22:27:07 +02:00
|
|
|
],
|
|
|
|
invalid: [
|
|
|
|
{
|
|
|
|
code: 'common.mustCall(assert.ifError)',
|
|
|
|
errors: [{ message: msg1 }]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
code: 'common.mustCall((err) => assert.ifError(err))',
|
|
|
|
errors: [{ message: msg2 }]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
code: 'common.mustCall((e) => assert.ifError(e))',
|
|
|
|
errors: [{ message: msg2 }]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
code: 'common.mustCall(function(e) { assert.ifError(e); })',
|
|
|
|
errors: [{ message: msg2 }]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
code: 'common.mustCall(function(e) { return assert.ifError(e); })',
|
|
|
|
errors: [{ message: msg2 }]
|
|
|
|
},
|
|
|
|
{
|
|
|
|
code: 'common.mustCall(function(e) {{ assert.ifError(e); }})',
|
|
|
|
errors: [{ message: msg2 }]
|
2021-03-26 08:51:08 -07:00
|
|
|
},
|
2020-09-06 22:27:07 +02:00
|
|
|
]
|
|
|
|
});
|