2016-02-03 16:07:44 -08:00
|
|
|
'use strict';
|
|
|
|
// This test was originally written to test a regression
|
|
|
|
// that was introduced by
|
|
|
|
// https://github.com/nodejs/node/pull/2288#issuecomment-179543894
|
|
|
|
require('../common');
|
|
|
|
|
|
|
|
const assert = require('assert');
|
|
|
|
const parse = require('querystring').parse;
|
|
|
|
|
2020-10-03 13:01:57 -07:00
|
|
|
// Taken from express-js/body-parser
|
|
|
|
// https://github.com/expressjs/body-parser/blob/ed25264fb494cf0c8bc992b8257092cd4f694d5e/test/urlencoded.js#L636-L651
|
2016-02-03 16:07:44 -08:00
|
|
|
function createManyParams(count) {
|
2017-01-08 13:19:00 +00:00
|
|
|
let str = '';
|
2016-02-03 16:07:44 -08:00
|
|
|
|
|
|
|
if (count === 0) {
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
|
|
|
|
str += '0=0';
|
|
|
|
|
2017-01-08 13:19:00 +00:00
|
|
|
for (let i = 1; i < count; i++) {
|
|
|
|
const n = i.toString(36);
|
2017-04-28 04:06:42 +03:00
|
|
|
str += `&${n}=${n}`;
|
2016-02-03 16:07:44 -08:00
|
|
|
}
|
|
|
|
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
|
|
|
|
const count = 10000;
|
|
|
|
const originalMaxLength = 1000;
|
|
|
|
const params = createManyParams(count);
|
|
|
|
|
|
|
|
// thealphanerd
|
2018-10-06 21:09:29 -04:00
|
|
|
// 27def4f introduced a change to parse that would cause Infinity
|
2016-02-03 16:07:44 -08:00
|
|
|
// to be passed to String.prototype.split as an argument for limit
|
|
|
|
// In this instance split will always return an empty array
|
|
|
|
// this test confirms that the output of parse is the expected length
|
|
|
|
// when passed Infinity as the argument for maxKeys
|
2017-07-10 20:55:21 -04:00
|
|
|
const resultInfinity = parse(params, undefined, undefined, {
|
|
|
|
maxKeys: Infinity
|
|
|
|
});
|
|
|
|
const resultNaN = parse(params, undefined, undefined, {
|
|
|
|
maxKeys: NaN
|
|
|
|
});
|
2016-02-03 16:07:44 -08:00
|
|
|
const resultInfinityString = parse(params, undefined, undefined, {
|
|
|
|
maxKeys: 'Infinity'
|
|
|
|
});
|
2017-07-10 20:55:21 -04:00
|
|
|
const resultNaNString = parse(params, undefined, undefined, {
|
|
|
|
maxKeys: 'NaN'
|
|
|
|
});
|
2016-02-03 16:07:44 -08:00
|
|
|
|
|
|
|
// Non Finite maxKeys should return the length of input
|
2017-01-08 15:36:25 +00:00
|
|
|
assert.strictEqual(Object.keys(resultInfinity).length, count);
|
|
|
|
assert.strictEqual(Object.keys(resultNaN).length, count);
|
2016-02-03 16:07:44 -08:00
|
|
|
// Strings maxKeys should return the maxLength
|
|
|
|
// defined by parses internals
|
2017-01-08 15:36:25 +00:00
|
|
|
assert.strictEqual(Object.keys(resultInfinityString).length, originalMaxLength);
|
|
|
|
assert.strictEqual(Object.keys(resultNaNString).length, originalMaxLength);
|