Logo
Explore Help
Sign In
1berry/nodejs
1
0
Fork 0
You've already forked nodejs
Code Issues Packages Projects Releases Wiki Activity
nodejs/test/parallel/test-stream-readable-to-web-termination.js

13 lines
292 B
JavaScript
Raw Permalink Normal View History

lib: fix unhandled errors in webstream adapters WebStream's Readable controller does not tolerate `.close()` being called after an `error`. However, when wrapping a Node's Readable stream it is possible that the sequence of events leads to `finished()`'s callback being invoked after such `error`. In order to handle this, in this change we call the `finished()` handler earlier when controller is canceled, and always handle this as an error case. Fix: https://github.com/nodejs/node/issues/54205 PR-URL: https://github.com/nodejs/node/pull/54206 Fixes: https://github.com/nodejs/node/issues/54205 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2024-08-06 11:34:35 -07:00
'use strict';
require('../common');
const { Readable } = require('stream');
{
const r = Readable.from([]);
// Cancelling reader while closing should not cause uncaught exceptions
r.on('close', () => reader.cancel());
const reader = Readable.toWeb(r).getReader();
reader.read();
}
Reference in New Issue Copy Permalink
Powered by Gitea Version: 1.23.8 Page: 1151ms Template: 2ms
English
Bahasa Indonesia Deutsch English Español Français Gaeilge Italiano Latviešu Magyar nyelv Nederlands Polski Português de Portugal Português do Brasil Suomi Svenska Türkçe Čeština Ελληνικά Български Русский Українська فارسی മലയാളം 日本語 简体中文 繁體中文(台灣) 繁體中文(香港) 한국어
Licenses API