nodejs/test/parallel/test-worker-exit-event-error.js

'use strict';
const common = require('../common');
const { Worker } = require('worker_threads');

process.on('uncaughtException', common.mustCall());

new Worker('', { eval: true })
  .on('exit', common.mustCall(() => { throw new Error('foo'); }));
worker: move JoinThread() back into exit callback de2c68c7dd17a217a818ea881e433034006fdb4b moved this call to the destructor, under the assumption that that would essentially be equivalent to running it as part of the callback since the worker would be destroyed along with the callback. However, the actual code in `Environment::RunAndClearNativeImmediates()` comes with the subtlety that testing whether a JS exception has been thrown happens between the invocation of the callback and its destruction, leaving a possible exception from `JoinThread()` potentially unhandled (and unintentionally silenced through the `TryCatch`). This affected exceptions thrown from the `'exit'` event of the Worker, and made the `parallel/test-worker-message-type-unknown` test flaky, as the invalid message was sometimes only received during the Worker thread’s exit handler. Fix this by moving the `JoinThread()` call back to where it was before. Refs: https://github.com/nodejs/node/pull/31386 PR-URL: https://github.com/nodejs/node/pull/31468 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> 2020-01-22 23:23:21 +01:00			`'use strict';`
			`const common = require('../common');`
			`const { Worker } = require('worker_threads');`

			`process.on('uncaughtException', common.mustCall());`

			`new Worker('', { eval: true })`
			`.on('exit', common.mustCall(() => { throw new Error('foo'); }));`