1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "build: remove precompiled header and debug information for host builds"

Browse Source 
This reverts commit 818284b68737bbb9098cf12b1b221cbb24f06ce8.

Reverted commit is a no longer needed patch for ARM64 cross-compiling.
It was increasing cross-compile time drastically (~3 times longer).

PR-URL: https://github.com/nodejs/node/pull/45432
Refs: https://github.com/nodejs/node/pull/42538
Refs: https://github.com/nodejs/node/issues/42375
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
This commit is contained in:
Stefan Stojanovic 2022-11-18 20:41:01 +01:00 committed by GitHub
parent 770efeab6d
commit 1f63c953e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
common.gypi
View File

@ -283,11 +283,7 @@
'-std:c++17' '-std:c++17'
], ],
'BufferSecurityCheck': 'true', 'BufferSecurityCheck': 'true',
'target_conditions': [ 'DebugInformationFormat': 1, # /Z7 embed info in .obj files
['_toolset=="target"', {
'DebugInformationFormat': 1 # /Z7 embed info in .obj files
}],
],
'ExceptionHandling': 0, # /EHsc 'ExceptionHandling': 0, # /EHsc
'MultiProcessorCompilation': 'true', 'MultiProcessorCompilation': 'true',
'StringPooling': 'true', # pool string literals 'StringPooling': 'true', # pool string literals

12
tools/v8_gypfiles/v8.gyp
View File

@ -325,7 +325,7 @@
'<(V8_ROOT)/src/builtins/builtins-intl-gen.cc', '<(V8_ROOT)/src/builtins/builtins-intl-gen.cc',
], ],
}], }],
['OS=="win" and _toolset=="target"', { ['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [ 'sources': [
@ -683,7 +683,7 @@
], ],
'sources': ['<@(v8_compiler_sources)'], 'sources': ['<@(v8_compiler_sources)'],
'conditions': [ 'conditions': [
['OS=="win" and _toolset=="target"', { ['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [ 'sources': [
@ -708,7 +708,7 @@
], ],
'sources': ['<@(v8_compiler_sources)'], 'sources': ['<@(v8_compiler_sources)'],
'conditions': [ 'conditions': [
['OS=="win" and _toolset=="target"', { ['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [ 'sources': [
@ -908,15 +908,13 @@
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")', '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_current_cpu == \\"loong64\\".*?sources \\+= ")',
], ],
}], }],
['OS=="win" and _toolset=="target"', { ['OS=="win"', {
'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h', 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc', 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
'sources': [ 'sources': [
'<(_msvs_precompiled_header)', '<(_msvs_precompiled_header)',
'<(_msvs_precompiled_source)', '<(_msvs_precompiled_source)',
] ],
}],
['OS=="win"', {
# This will prevent V8's .cc files conflicting with the inspector's # This will prevent V8's .cc files conflicting with the inspector's
# .cpp files in the same shard. # .cpp files in the same shard.
'msvs_settings': { 'msvs_settings': {