1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

buffer: fix Blob constructor on various TypedArrays

Browse Source 
Fixes: https://github.com/nodejs/node/issues/40705
    
PR-URL: https://github.com/nodejs/node/pull/40706
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Irakli Gozalishvili 2021-12-10 15:36:20 -08:00 committed by GitHub
parent 98ec909f2b
commit 2e1fa8ab28
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/internal/blob.js
View File

@ -114,10 +114,10 @@ function getSource(source, endings) {
// We copy into a new Uint8Array because the underlying // We copy into a new Uint8Array because the underlying
// BackingStores are going to be detached and owned by // BackingStores are going to be detached and owned by
// the Blob. We also don't want to have to worry about // the Blob.
// byte offsets. const { buffer, byteOffset, byteLength } = source;
source = new Uint8Array(source); const slice = buffer.slice(byteOffset, byteOffset + byteLength);
return [source.byteLength, source]; return [byteLength, new Uint8Array(slice)];
} }
class Blob { class Blob {

15
test/parallel/test-blob.js
View File

@ -229,3 +229,18 @@ assert.throws(() => new Blob({}), {
}); });
}); });
} }
(async () => {
const blob = new Blob([
new Uint8Array([0x50, 0x41, 0x53, 0x53]),
new Int8Array([0x50, 0x41, 0x53, 0x53]),
new Uint16Array([0x4150, 0x5353]),
new Int16Array([0x4150, 0x5353]),
new Uint32Array([0x53534150]),
new Int32Array([0x53534150]),
new Float32Array([0xD341500000]),
]);
assert.strictEqual(blob.size, 28);
assert.strictEqual(blob.type, '');
})().then(common.mustCall());