1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tls: always reset this.ssl.error after handling

Browse Source 
Otherwise assertion may happen:

    src/node_crypto.cc:962: void node::crypto::Connection::ClearError():
    Assertion `handle_->Get(String::New("error"))->BooleanValue() == false'
    failed.

See #5058
This commit is contained in:
Fedor Indutny 2013-03-20 17:35:38 +04:00
parent 25eaacad9a
commit 34e22b8ee7
1 changed files with 14 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/tls.js
View File

@ -906,30 +906,25 @@ SecurePair.prototype.destroy = function() {
SecurePair.prototype.error = function() {
var err = this.ssl.error;
this.ssl.error = null;
if (!this._secureEstablished) {
var error = this.ssl.error;
if (!error) {
error = new Error('socket hang up');
error.code = 'ECONNRESET';
if (!err) {
err = new Error('socket hang up');
err.code = 'ECONNRESET';
}
this.destroy();
this.emit('error', error);
return error;
this.emit('error', err);
} else if (this._isServer &&
this._rejectUnauthorized &&
/peer did not return a certificate/.test(err.message)) {
// Not really an error.
this.destroy();
} else {
var err = this.ssl.error;
this.ssl.error = null;
if (this._isServer &&
this._rejectUnauthorized &&
/peer did not return a certificate/.test(err.message)) {
// Not really an error.
this.destroy();
} else {
this.cleartext.emit('error', err);
}
return err;
this.cleartext.emit('error', err);
}
return err;
};
// TODO: support anonymous (nocert) and PSK