1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: revise test-http-client-default-headers-exist

Browse Source 
* Remove assert.strictEqual where assert.ok suffices
* Replace countdown with Promise.all()

PR-URL: https://github.com/nodejs/node/pull/32493
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This commit is contained in:
Rich Trott 2020-03-25 14:55:50 -07:00
parent c399e2664b
commit 436c71db66
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/parallel/test-http-client-default-headers-exist.js
View File

@ -23,7 +23,8 @@
const common = require('../common'); const common = require('../common');
const assert = require('assert'); const assert = require('assert');
const http = require('http'); const http = require('http');
const Countdown = require('../common/countdown');
const { once } = require('events');
const expectedHeaders = { const expectedHeaders = {
'DELETE': ['host', 'connection'], 'DELETE': ['host', 'connection'],
@ -37,10 +38,6 @@ const expectedHeaders = {
const expectedMethods = Object.keys(expectedHeaders); const expectedMethods = Object.keys(expectedHeaders);
const countdown =
new Countdown(expectedMethods.length,
common.mustCall(() => server.close()));
const server = http.createServer(common.mustCall((req, res) => { const server = http.createServer(common.mustCall((req, res) => {
res.end(); res.end();
@ -49,9 +46,8 @@ const server = http.createServer(common.mustCall((req, res) => {
const requestHeaders = Object.keys(req.headers); const requestHeaders = Object.keys(req.headers);
requestHeaders.forEach((header) => { requestHeaders.forEach((header) => {
assert.strictEqual( assert.ok(
expectedHeaders[req.method].includes(header.toLowerCase()), expectedHeaders[req.method].includes(header.toLowerCase()),
true,
`${header} should not exist for method ${req.method}` `${header} should not exist for method ${req.method}`
); );
}); });
@ -61,15 +57,14 @@ const server = http.createServer(common.mustCall((req, res) => {
expectedHeaders[req.method].length, expectedHeaders[req.method].length,
`some headers were missing for method: ${req.method}` `some headers were missing for method: ${req.method}`
); );
countdown.dec();
}, expectedMethods.length)); }, expectedMethods.length));
server.listen(0, common.mustCall(() => { server.listen(0, common.mustCall(() => {
expectedMethods.forEach((method) => { Promise.all(expectedMethods.map(async (method) => {
http.request({ const request = http.request({
method: method, method: method,
port: server.address().port port: server.address().port
}).end(); }).end();
}); return once(request, 'response');
})).then(common.mustCall(() => { server.close(); }));
})); }));