From 49679ddd9833dbfd20ef7af1bf8bd3d67e41993f Mon Sep 17 00:00:00 2001 From: Yuesong Jake Li Date: Wed, 28 May 2025 09:27:34 +0930 Subject: [PATCH] Revert "benchmark: fix broken fs.cpSync benchmark" This reverts commit 52430b9839c31f846a788125efda82887d115e21. PR-URL: https://github.com/nodejs/node/pull/58476 Fixes: https://github.com/nodejs/node/issues/58468 Reviewed-By: Dario Piotrowicz --- benchmark/fs/bench-cpSync.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/benchmark/fs/bench-cpSync.js b/benchmark/fs/bench-cpSync.js index 822036726d1..fa6350384c6 100644 --- a/benchmark/fs/bench-cpSync.js +++ b/benchmark/fs/bench-cpSync.js @@ -8,10 +8,7 @@ const tmpdir = require('../../test/common/tmpdir'); const bench = common.createBenchmark(main, { n: [1, 100, 10_000], dereference: ['true', 'false'], - // When `force` is `true` the `cpSync` function is called twice the second - // time however an `ERR_FS_CP_EINVAL` is thrown, so skip `true` for the time being - // TODO: allow `force` to also be `true` once https://github.com/nodejs/node/issues/58468 is addressed - force: ['false'], + force: ['true', 'false'], }); function prepareTestDirectory() {