1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

repl: do not insert duplicates into completions

Browse Source 
Fix invalid `hasOwnProperty` function usage.

For example, before in the REPL:

```
> Ar<Tab>
Array

Array        ArrayBuffer
```

Now:

```
> Ar<Tab>
Array

ArrayBuffer
```

Fixes #6255.
Closes #6498.
This commit is contained in:
Maciej Małecki 2013-11-12 00:03:29 +01:00 committed by Nathan Rajlich
parent 2010985354
commit 568072ceae
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/repl.js
View File

@ -641,7 +641,7 @@ REPLServer.prototype.complete = function(line, callback) {
group.sort(); group.sort();
for (var j = 0; j < group.length; j++) { for (var j = 0; j < group.length; j++) {
c = group[j]; c = group[j];
if (!hasOwnProperty(c)) { if (!hasOwnProperty(uniq, c)) {
completions.push(c); completions.push(c);
uniq[c] = true; uniq[c] = true;
} }

3
test/simple/test-repl-tab-complete.js
View File

@ -55,6 +55,9 @@ putIn.run([
testMe.complete('inner.o', function(error, data) { testMe.complete('inner.o', function(error, data) {
assert.deepEqual(data, doesNotBreak); assert.deepEqual(data, doesNotBreak);
}); });
testMe.complete('console.lo', function(error, data) {
assert.deepEqual(data, [['console.log'], 'console.lo']);
});
// Tab Complete will return globaly scoped variables // Tab Complete will return globaly scoped variables
putIn.run(['};']); putIn.run(['};']);