http: null the joinDuplicateHeaders property on cleanup
Null the `joinDuplicateHeaders` property when the parser is freed. Refs: https://github.com/nodejs/node/pull/45982 PR-URL: https://github.com/nodejs/node/pull/48608 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
This commit is contained in:
parent
acf071e9d5
commit
651c02cbbc
@ -236,6 +236,7 @@ function cleanParser(parser) {
|
|||||||
parser[kOnTimeout] = null;
|
parser[kOnTimeout] = null;
|
||||||
parser._consumed = false;
|
parser._consumed = false;
|
||||||
parser.onIncoming = null;
|
parser.onIncoming = null;
|
||||||
|
parser.joinDuplicateHeaders = null;
|
||||||
}
|
}
|
||||||
|
|
||||||
function prepareError(err, parser, rawPacket) {
|
function prepareError(err, parser, rawPacket) {
|
||||||
|
@ -25,18 +25,24 @@ server.on('request', common.mustCall((request, response) => {
|
|||||||
}));
|
}));
|
||||||
|
|
||||||
server.listen(common.mustCall(() => {
|
server.listen(common.mustCall(() => {
|
||||||
const request = http.get({ port: server.address().port });
|
const request = http.get({
|
||||||
|
headers: { Connection: 'close' },
|
||||||
|
port: server.address().port,
|
||||||
|
joinDuplicateHeaders: true
|
||||||
|
});
|
||||||
let parser;
|
let parser;
|
||||||
|
|
||||||
request.on('socket', common.mustCall(() => {
|
request.on('socket', common.mustCall(() => {
|
||||||
parser = request.parser;
|
parser = request.parser;
|
||||||
assert.strictEqual(typeof parser.onIncoming, 'function');
|
assert.strictEqual(typeof parser.onIncoming, 'function');
|
||||||
|
assert.strictEqual(parser.joinDuplicateHeaders, true);
|
||||||
}));
|
}));
|
||||||
|
|
||||||
request.on('response', common.mustCall((response) => {
|
request.on('response', common.mustCall((response) => {
|
||||||
response.resume();
|
response.resume();
|
||||||
response.on('end', common.mustCall(() => {
|
response.on('end', common.mustCall(() => {
|
||||||
assert.strictEqual(parser.onIncoming, null);
|
assert.strictEqual(parser.onIncoming, null);
|
||||||
|
assert.strictEqual(parser.joinDuplicateHeaders, null);
|
||||||
}));
|
}));
|
||||||
}));
|
}));
|
||||||
}));
|
}));
|
||||||
|
Loading…
x
Reference in New Issue
Block a user