1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

deps: always define V8_EXPORT_PRIVATE as no-op

Browse Source 
dllexport introduces issues when compiling with MSVC.

PR-URL: https://github.com/nodejs/node/pull/47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This commit is contained in:
Michaël Zasso 2022-09-21 15:47:37 +02:00 committed by Node.js GitHub Bot
parent 17a17164d6
commit 69ad89f8eb
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@ -36,7 +36,7 @@
# Reset this number to 0 on major V8 upgrades. # Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8. # Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.0', 'v8_embedder_string': '-node.1',
##### V8 defaults for Node.js ##### ##### V8 defaults for Node.js #####

8
deps/v8/src/base/macros.h vendored
View File

@ -423,9 +423,9 @@ bool is_inbounds(float_t v) {
// Setup for Windows shared library export. // Setup for Windows shared library export.
#define V8_EXPORT_ENUM #define V8_EXPORT_ENUM
#ifdef BUILDING_V8_SHARED_PRIVATE #ifdef BUILDING_V8_SHARED_PRIVATE
#define V8_EXPORT_PRIVATE __declspec(dllexport) #define V8_EXPORT_PRIVATE
#elif USING_V8_SHARED_PRIVATE #elif USING_V8_SHARED_PRIVATE
#define V8_EXPORT_PRIVATE __declspec(dllimport) #define V8_EXPORT_PRIVATE
#else #else
#define V8_EXPORT_PRIVATE #define V8_EXPORT_PRIVATE
#endif // BUILDING_V8_SHARED #endif // BUILDING_V8_SHARED
@ -435,8 +435,8 @@ bool is_inbounds(float_t v) {
// Setup for Linux shared library export. // Setup for Linux shared library export.
#if V8_HAS_ATTRIBUTE_VISIBILITY #if V8_HAS_ATTRIBUTE_VISIBILITY
#ifdef BUILDING_V8_SHARED_PRIVATE #ifdef BUILDING_V8_SHARED_PRIVATE
#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) #define V8_EXPORT_PRIVATE
#define V8_EXPORT_ENUM V8_EXPORT_PRIVATE #define V8_EXPORT_ENUM
#else #else
#define V8_EXPORT_PRIVATE #define V8_EXPORT_PRIVATE
#define V8_EXPORT_ENUM #define V8_EXPORT_ENUM