1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: simplify text in pull-requests.md

Browse Source 
Mostly, this replaces "It is recommended to do X" with "Do X."

PR-URL: https://github.com/nodejs/node/pull/30458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Rich Trott 2019-11-12 19:50:09 -08:00
parent c71b89eb06
commit 794d8be94e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
doc/guides/contributing/pull-requests.md
View File

@ -73,7 +73,7 @@ $ git remote add upstream https://github.com/nodejs/node.git
$ git fetch upstream $ git fetch upstream
``` ```
It is recommended to configure `git` so that it knows who you are: Configure `git` so that it knows who you are:
```text ```text
$ git config user.name "J. Random User" $ git config user.name "J. Random User"
@ -125,7 +125,7 @@ For contributing C++ code, you may want to look at the
### Step 4: Commit ### Step 4: Commit
It is a recommended best practice to keep your changes as logically grouped It is a best practice to keep your changes as logically grouped
as possible within individual commits. There is no limit to the number of as possible within individual commits. There is no limit to the number of
commits any single Pull Request may have, and many contributors find it easier commits any single Pull Request may have, and many contributors find it easier
to review changes that are split across multiple commits. to review changes that are split across multiple commits.