1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: optimize copyError with ObjectAssign in primordials

Browse Source 
optimized the copyError function by using ObjectAssign from primordials.
this change replaces the for-loop with ObjectAssign, which improves
memory usage and performance.

this change updates the copyError function in internal/assert.js to
use ObjectAssign for copying properties.

PR-URL: https://github.com/nodejs/node/pull/53999
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
This commit is contained in:
HEESEUNG 2024-07-25 21:12:35 +09:00 committed by GitHub
parent 852a1a6742
commit 87e18a7b37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/internal/assert/assertion_error.js
View File

@ -6,9 +6,9 @@ const {
Error, Error,
ErrorCaptureStackTrace, ErrorCaptureStackTrace,
MathMax, MathMax,
ObjectAssign,
ObjectDefineProperty, ObjectDefineProperty,
ObjectGetPrototypeOf, ObjectGetPrototypeOf,
ObjectKeys,
String, String,
StringPrototypeEndsWith, StringPrototypeEndsWith,
StringPrototypeRepeat, StringPrototypeRepeat,
@ -46,11 +46,7 @@ const kReadableOperator = {
const kMaxShortLength = 12; const kMaxShortLength = 12;
function copyError(source) { function copyError(source) {
const keys = ObjectKeys(source); const target = ObjectAssign({ __proto__: ObjectGetPrototypeOf(source) }, source);
const target = { __proto__: ObjectGetPrototypeOf(source) };
for (const key of keys) {
target[key] = source[key];
}
ObjectDefineProperty(target, 'message', { __proto__: null, value: source.message }); ObjectDefineProperty(target, 'message', { __proto__: null, value: source.message });
return target; return target;
} }