1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: remove error allowance in debugger test

Browse Source 
Remove allowance for FATAL ERROR. It is no longer needed.

PR-URL: https://github.com/nodejs/node/pull/41640
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
This commit is contained in:
Jithil P Ponnan 2022-01-25 07:08:05 +05:30 committed by GitHub
parent b27ae24dcc
commit 938ab0e267
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
test/sequential/test-debugger-exceptions.js
View File

@ -27,8 +27,7 @@ const path = require('path');
})
// Making sure it will die by default:
.then(() => cli.command('c'))
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore.
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))
.then(() => cli.waitFor(/disconnect/))
// Next run: With `breakOnException` it pauses in both places.
.then(() => cli.stepCommand('r'))
@ -66,9 +65,7 @@ const path = require('path');
assert.deepStrictEqual(cli.breakInfo, { filename: script, line: 1 });
})
.then(() => cli.command('c'))
// TODO: Remove FATAL ERROR once node doesn't show a FATAL ERROR anymore
.then(() => cli.waitFor(/disconnect|FATAL ERROR/))
.then(() => cli.waitFor(/disconnect/))
.then(() => cli.quit())
.then(null, onFatal);
}