1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

doc: onboarding process extras

Browse Source 
Callout some practices explicitly, so that
the process is followed in a similar manner

PR-URL: https://github.com/nodejs/node/pull/34455
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
This commit is contained in:
Gireesh Punathil 2020-07-21 08:14:45 +05:30
parent adcf12c39f
commit 983364c0ff
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
onboarding.md
View File

@ -210,6 +210,9 @@ needs to be pointed out separately during the onboarding.
* Run CI on the PR. Use the `node-test-pull-request` CI task. * Run CI on the PR. Use the `node-test-pull-request` CI task.
* After two Collaborator approvals for the change and two Collaborator approvals * After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the PR. for fast-tracking, land the PR.
* Leave a comment in the PR: `Please 👍 this comment to approve fast-tracking`.
* If there are not enough approvals within a reasonable time, consider the
single approval of the onboarding TSC member sufficient, and land the PR.
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
metadata. metadata.
* [`node-core-utils`][] automates the generation of metadata and the landing * [`node-core-utils`][] automates the generation of metadata and the landing