Fix #1707 hasOwnProperty usage

This commit is contained in:
isaacs 2011-09-15 09:46:30 -07:00
parent 5724b54d2e
commit 98990b9779
3 changed files with 20 additions and 3 deletions

View File

@ -25,6 +25,12 @@ var runInThisContext = Script.runInThisContext;
var runInNewContext = Script.runInNewContext; var runInNewContext = Script.runInNewContext;
var assert = require('assert').ok; var assert = require('assert').ok;
function hOP(obj, prop) {
return Object.prototype.hasOwnProperty.call(obj, prop);
}
function Module(id, parent) { function Module(id, parent) {
this.id = id; this.id = id;
this.exports = {}; this.exports = {};
@ -85,7 +91,7 @@ function statPath(path) {
var packageCache = {}; var packageCache = {};
function readPackage(requestPath) { function readPackage(requestPath) {
if (packageCache.hasOwnProperty(requestPath)) { if (hOP(packageCache, requestPath)) {
return packageCache[requestPath]; return packageCache[requestPath];
} }

View File

@ -25,6 +25,11 @@ var QueryString = exports;
var urlDecode = process.binding('http_parser').urlDecode; var urlDecode = process.binding('http_parser').urlDecode;
function hOP(obj, prop) {
return Object.prototype.hasOwnProperty.call(obj, prop);
}
function charCode(c) { function charCode(c) {
return c.charCodeAt(0); return c.charCodeAt(0);
} }
@ -166,7 +171,7 @@ QueryString.parse = QueryString.decode = function(qs, sep, eq) {
var k = QueryString.unescape(x[0], true); var k = QueryString.unescape(x[0], true);
var v = QueryString.unescape(x.slice(1).join(eq), true); var v = QueryString.unescape(x.slice(1).join(eq), true);
if (!obj.hasOwnProperty(k)) { if (!hOP(obj, k)) {
obj[k] = v; obj[k] = v;
} else if (!Array.isArray(obj[k])) { } else if (!Array.isArray(obj[k])) {
obj[k] = [obj[k], v]; obj[k] = [obj[k], v];

View File

@ -46,6 +46,12 @@ var path = require('path');
var fs = require('fs'); var fs = require('fs');
var rl = require('readline'); var rl = require('readline');
function hOP(obj, prop) {
return Object.prototype.hasOwnProperty.call(obj, prop);
}
var context; var context;
var disableColors = true; var disableColors = true;
@ -446,7 +452,7 @@ REPLServer.prototype.complete = function(line) {
group.sort(); group.sort();
for (var j = 0; j < group.length; j++) { for (var j = 0; j < group.length; j++) {
c = group[j]; c = group[j];
if (!uniq.hasOwnProperty(c)) { if (!hOP(uniq, c)) {
completions.push(c); completions.push(c);
uniq[c] = true; uniq[c] = true;
} }