1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

lib: update TODO comments

Browse Source 
This removes one TODO comment and adds another that indicates that
readline is currently not able to trigger specific escape sequences.

Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: https://github.com/nodejs/node/pull/33361
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This commit is contained in:
Ruben Bridgewater 2020-05-11 23:11:33 +02:00 committed by Anna Henningsen
parent da7be6979e
commit 9de08f773e
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/readline.js
View File

@ -855,6 +855,8 @@ Interface.prototype._ttyWrite = function(s, key) {
if (key.ctrl && key.shift) { if (key.ctrl && key.shift) {
/* Control and shift pressed */ /* Control and shift pressed */
switch (key.name) { switch (key.name) {
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
case 'backspace': case 'backspace':
this._deleteLineLeft(); this._deleteLineLeft();
break; break;
@ -952,8 +954,10 @@ Interface.prototype._ttyWrite = function(s, key) {
} }
break; break;
// TODO(BridgeAR): This seems broken?
case 'w': // Delete backwards to a word boundary case 'w': // Delete backwards to a word boundary
// TODO(BridgeAR): The transmitted escape sequence is `\b` and that is
// identical to <ctrl>-h. It should have a unique escape sequence.
// Falls through
case 'backspace': case 'backspace':
this._deleteWordLeft(); this._deleteWordLeft();
break; break;

2
test/parallel/test-assert-deep.js
View File

@ -957,8 +957,6 @@ assertDeepAndStrictEqual(obj1, obj2);
// Check proxies. // Check proxies.
{ {
// TODO(BridgeAR): Check if it would not be better to detect proxies instead
// of just using the proxy value.
const arrProxy = new Proxy([1, 2], {}); const arrProxy = new Proxy([1, 2], {});
assert.deepStrictEqual(arrProxy, [1, 2]); assert.deepStrictEqual(arrProxy, [1, 2]);
const tmp = util.inspect.defaultOptions; const tmp = util.inspect.defaultOptions;