1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: usemustSucceed instead of mustCall with assert.ifError

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/42806
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
MURAKAMI Masahiko 2022-05-05 20:48:46 +09:00 committed by GitHub
parent 277353c902
commit a571a3fed1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/parallel/test-fs-opendir.js
View File

@ -67,18 +67,16 @@ const invalidCallbackObj = {
// Check the opendir async version // Check the opendir async version
fs.opendir(testDir, common.mustSucceed((dir) => { fs.opendir(testDir, common.mustSucceed((dir) => {
let sync = true; let sync = true;
dir.read(common.mustCall((err, dirent) => { dir.read(common.mustSucceed((dirent) => {
assert(!sync); assert(!sync);
assert.ifError(err);
// Order is operating / file system dependent // Order is operating / file system dependent
assert(files.includes(dirent.name), `'files' should include ${dirent}`); assert(files.includes(dirent.name), `'files' should include ${dirent}`);
assertDirent(dirent); assertDirent(dirent);
let syncInner = true; let syncInner = true;
dir.read(common.mustCall((err, dirent) => { dir.read(common.mustSucceed((dirent) => {
assert(!syncInner); assert(!syncInner);
assert.ifError(err);
dir.close(common.mustSucceed()); dir.close(common.mustSucceed());
})); }));