1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

src: remove separate definitions for static constexpr members

Browse Source 
This is no longer necessary (and actually deprecated) since C++17.

PR-URL: https://github.com/nodejs/node/pull/41755
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This commit is contained in:
Anna Henningsen 2022-02-11 17:42:09 +01:00 committed by GitHub
parent 91d28d8b46
commit b51eba422f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 0 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/async_wrap.cc
View File

@ -151,9 +151,6 @@ void AsyncWrap::EmitAfter(Environment* env, double async_id) {
env->async_hooks_after_function());
}
// TODO(addaleax): Remove once we're on C++17.
constexpr double AsyncWrap::kInvalidAsyncId;
static void SetupHooks(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);

2
src/node_blob.cc
View File

@ -482,8 +482,6 @@ InternalFieldInfo* BlobBindingData::Serialize(int index) {
return info;
}
constexpr FastStringKey BlobBindingData::type_name;
void Blob::RegisterExternalReferences(ExternalReferenceRegistry* registry) {
registry->Register(Blob::New);
registry->Register(Blob::ToArrayBuffer);

3
src/node_file.cc
View File

@ -2449,9 +2449,6 @@ InternalFieldInfo* BindingData::Serialize(int index) {
return info;
}
// TODO(addaleax): Remove once we're on C++17.
constexpr FastStringKey BindingData::type_name;
void Initialize(Local<Object> target,
Local<Value> unused,
Local<Context> context,

3
src/node_http2.cc
View File

@ -3135,9 +3135,6 @@ void Http2State::MemoryInfo(MemoryTracker* tracker) const {
tracker->TrackField("root_buffer", root_buffer);
}
// TODO(addaleax): Remove once we're on C++17.
constexpr FastStringKey Http2State::type_name;
// Set up the process.binding('http2') binding.
void Initialize(Local<Object> target,
Local<Value> unused,

3
src/node_http_parser.cc
View File

@ -107,9 +107,6 @@ class BindingData : public BaseObject {
SET_MEMORY_INFO_NAME(BindingData)
};
// TODO(addaleax): Remove once we're on C++17.
constexpr FastStringKey BindingData::type_name;
// helper class for the Parser
struct StringPtr {
StringPtr() {

2
src/node_process_methods.cc
View File

@ -448,8 +448,6 @@ static void ReallyExit(const FunctionCallbackInfo<Value>& args) {
namespace process {
constexpr FastStringKey BindingData::type_name;
BindingData::BindingData(Environment* env, v8::Local<v8::Object> object)
: SnapshotableObject(env, object, type_int) {
Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), kBufferSize);

3
src/node_v8.cc
View File

@ -142,9 +142,6 @@ void BindingData::MemoryInfo(MemoryTracker* tracker) const {
heap_code_statistics_buffer);
}
// TODO(addaleax): Remove once we're on C++17.
constexpr FastStringKey BindingData::type_name;
void CachedDataVersionTag(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
Local<Integer> result =